Repository navigation
Create window.customCards if no card has yet - #244
Open
LeeS773-prog wants to merge 1 commit into
Open
LeeS773-prog wants to merge 1 commit into
LeeS773-prog wants to merge 1 commit into
Conversation
index.js pushes to window.customCards without creating it. If no card that loaded earlier has created the list, the push throws after the elements are defined: the card works, but it is missing from the card picker. Use the usual `window.customCards = window.customCards || []` first. Test: src/index.picker.test.js (2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index.jspushes towindow.customCardswithout creating it. If no card that loaded earlier has created the list, the push throws after the elements are defined: the card works, but it is missing from the card picker. This uses the usualwindow.customCards = window.customCards || []first.Tests:
src/index.picker.test.js(2; the first fails without the change). Full suite 195/195; eslint reports the same errors asmainand none in the files touched.