fix: accept cacheTTL: Infinity, keep rejecting NaN - #652
Merged
Conversation
Closed
4 tasks
Co-authored-by: SociableSteve <52213009+SociableSteve@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cacheTTL to accept Infinity value again
fix: accept Aug 4, 2026
cacheTTL: Infinity, keep rejecting NaN
SociableSteve
marked this pull request as ready for review
August 4, 2026 08:19
SociableSteve
approved these changes
Aug 4, 2026
SociableSteve
self-requested a review
August 4, 2026 08:20
SociableSteve
approved these changes
Aug 4, 2026
fangymeatball
approved these changes
Aug 4, 2026
SociableSteve
temporarily deployed
to
production
August 4, 2026 08:55 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#640inadvertently madecacheTTL: Infinitya breaking change by applying the sameNumber.isFiniteguard used for the security fix onclockTimestamp/clockTolerance. Unlike those options,cacheTTL: Infinityis safe — the cache window is always clamped to the token's ownexp, so no expired token is accepted.Changes
src/verifier.js— relaxcacheTTLguard from!Number.isFinitetoNumber.isNaN;clockTimestampandclockTolerancekeep theirisFinitechecktest/verifier.spec.js— remove the assertion thatInfinitythrows; add a test confirming an expired token is still rejected whencacheTTL: InfinityREADME.md— note thatInfinityis a valid value meaning "no cap beyond the token's own expiry"