Skip to content

feat: export numG and qSize - #9

Open
guilhem wants to merge 1 commit into
neilotoole:masterfrom
guilhem:export
Open

feat: export numG and qSize#9
guilhem wants to merge 1 commit into
neilotoole:masterfrom
guilhem:export

Conversation

@guilhem

@guilhem guilhem commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

This permit to create a group without using WithContext.
As cancel is nil, errgroup will not send a context close at first error.

This permit to create a group without using `WithContext`.
As cancel is nil, errgroup will not send a context close at first error.
@neilotoole

Copy link
Copy Markdown
Owner

@guilhem Apologies for the egregious delay in responding to you. Thank you for the PR.

One of the reasons that numG and qSize are unexported is because we don't want those field values to change during the lifetime of the Group... or at a minimum, updating those fields should be done atomically.

As cancel is nil, errgroup will not send a context close at first error.

Is this not desirable?

This permit to create a group without using WithContext.

Can you elaborate some more on the issue you're facing that this PR resolves? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants