Updated IClientMobEffectExtensions methods and mark old methods as deprecated for removal - #3202
Open
DBotThePony wants to merge 6 commits into
Open
Updated IClientMobEffectExtensions methods and mark old methods as deprecated for removal#3202DBotThePony wants to merge 6 commits into
DBotThePony wants to merge 6 commits into
Conversation
…s deprecated for removal
|
Member
|
This is still applicable for 26.2, right? Would you be willing to update your PR to 26.2, and implement the removals fully? |
sciwhiz12
added
enhancement
sciwhiz12
requested changes
Aug 29, 2026
sciwhiz12
left a comment
sciwhiz12
left a comment
Member
There was a problem hiding this comment.
Looks right to me. Just some Markdown conversions of the javadoc are needed.
DBotThePony
force-pushed
the
feat/mob-effect-rendering
branch
from
August 31, 2026 04:11
e929868 to
f2f693f
Compare
sciwhiz12
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses concern i outlined in NeoForge discord regarding old methods having arguments with no meaning after Mojang updated high-level rendering pipeline
Introduces no breaking changes, existing projects will continue to compile, as well as already compiled will continue to function as-is. Actively maintained projects should switch to new functions asap.