Skip to content

typo3-extension labeler: the tests glob only matches the layout being migrated away from #386

Description

@CybotTM

templates/typo3-extension/.github/labeler.yml labels test changes by this glob:

tests:
  - changed-files:
      - any-glob-to-any-file: ['Tests/**/*', 'Build/phpunit/**/*']

Build/phpunit/**/* is one of two layouts in the fleet, and it is the one being migrated away from. The reference layout — typo3-ci-workflows#186 — puts the configs at Build/phpunit.xml and Build/FunctionalTests.xml, which this glob does not match. Nine extensions are already on the Build/phpunit/ side, two are on the reference side, and the rest have no unit config at all; over the migration every one of them crosses from the first form to the second.

Found the hard way: t3x-nr-repurpose#98 moved its two configs and updated this glob to match — which is drift, because this file is template-owned. The drift check caught it and the change was reverted there. Correct call by the check; the glob still points at the layout being retired.

Why this is not a pull request yet

Changing a template file makes every consumer drift-red until it is synced, and scripts/sync-all-consumers.sh --template typo3-extension --dry-run lists 21 consumers. Twenty-one pull requests for one additional label is the wrong trade on its own — Build/**/* already matches both config paths under the ci label, so nothing goes unlabelled today, it just gets ci instead of tests.

So this is filed to be bundled into the next typo3-extension template round rather than shipped alone. The glob that covers both layouts during the migration:

      - any-glob-to-any-file: ['Tests/**/*', 'Build/phpunit.xml', 'Build/FunctionalTests.xml', 'Build/phpunit/**/*']

Once #186 is finished, the last entry can go.

Assisted by claude-code:claude-opus-5 — Session

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions