Fix ruff linting errors

Author: kirankotari

pingping/ping.py

@@ -44,7 +44,7 @@ def _set_ping(self, count, layer, timeout):
     @classmethod
     def is_valid_ip(cls, ip):
         m = re.match(r"^(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})$", str(ip).strip())
-        return bool(m) and all(map(lambda n: 0 <= int(n) <= 255, m.groups()))
+        return bool(m) and all(0 <= int(n) <= 255 for n in m.groups())
 
     def _add_ip(self, ip):
         if self.is_valid_ip(ip):
@@ -108,7 +108,9 @@ def _fetch_time(cls):
             return
 
     @classmethod
-    def _set_time(cls, result, index=[1, 2, 3]):
+    def _set_time(cls, result, index=None):
+        if index is None:
+            index = [1, 2, 3]
         if result:
             cls.ping_data["min"] = float(result.group(index[0]))
             cls.ping_data["avg"] = float(result.group(index[1]))

tests/test_ping.py

@@ -1,6 +1,5 @@
 import json
 import os
-import sys
 
 import pytest
 
@@ -12,24 +11,17 @@ class TestPing:
 
     @pytest.fixture
     def setup(self):
-        # Not a good way to solve the encoding issue.
-        if sys.version_info.major == 2:
-            import imp
-
-            imp.reload(sys)
-            sys.setdefaultencoding("utf-8")
-
         p = Ping()
         yield p
 
     def read_all_inputs(self, obj, langauge="en"):
         file_name = f"ping_{langauge}.json"
         ping_data = json.load(open(f"{self.file_path}/{file_name}"))
         result = {}
-        for os, os_result in ping_data.items():
-            result[os] = {}
+        for os_name, os_result in ping_data.items():
+            result[os_name] = {}
             for ip, each_ping in os_result.items():
-                result[os][ip] = obj.fetch_ping_data(each_ping)
+                result[os_name][ip] = obj.fetch_ping_data(each_ping)
         return result
 
     def validate_result(self, result):