Skip to content

Non-string keys? #1

Description

@sun

I don't know whether this is an actual problem, only stumbled over the question while reviewing the code:

primary = cloner.deep.merge(secondary, primary);

Shouldn't this be merging the requested key only?

 primary[keyName] = cloner.deep.merge(secondary[keyName], primary[keyName]);

… so that only the specified key is merged, regardless of what type it is?

Feel free to close if invalid.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions