Making MSCL IMU import works across different mscl versions - #493
Merged
Conversation
tkevinbest
approved these changes
Sep 19, 2025
tkevinbest
left a comment
tkevinbest
left a comment
Member
There was a problem hiding this comment.
Looks good on my end. I assume this has been tested for both versions.
senthurayyappan
approved these changes
Sep 19, 2025
senthurayyappan
left a comment
senthurayyappan
left a comment
Member
There was a problem hiding this comment.
Looks good!
ModuleNotFoundError is a subclass of ImportError, so it is redundant to mention it in the except statement, but it doesn't have any side effects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newer version of mscl does not create python bindings in "/usr/share/python3-mscl" instead it is stored in "dist-packages".
Specifically