Skip to content

feat: add Hall effect, ADC, and encoder counter sensor classes - #530

Closed
ninankh wants to merge 5 commits into
neurobionics:mainfrom
ninankh:vso_update_sensors
Closed

feat: add Hall effect, ADC, and encoder counter sensor classes#530
ninankh wants to merge 5 commits into
neurobionics:mainfrom
ninankh:vso_update_sensors

Conversation

@ninankh

@ninankh ninankh commented Aug 13, 2026

Copy link
Copy Markdown

Summary

Adds the base sensor class along with three sensor driver implementations:

  • DRV5056 Hall effect sensor
  • ADS114S0x ADC sensor
  • LS7366R Encoder counter sensor

Unit tests are included for the base class and all three drivers.

Changes

  • base sensor class: shared interface/abstract methods used by the new sensor drivers
  • hall effect sensor: driver implementation
  • adc sensor: driver implementation
  • encoder counter sensor: driver implementation
  • Unit tests added for each of the above under tests/

Testing

  • Added pytest coverage for all four modules
  • Ran make test locally, all passing
  • Ran make check for lint/format compliance

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.56115% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
opensourceleg/sensors/adc.py 98.3% 8 Missing and 1 partial ⚠️
opensourceleg/sensors/hall.py 98.4% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@ninankh ninankh closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants