feat: add Hall effect, ADC, and encoder counter sensor classes - #530
Closed
ninankh wants to merge 5 commits into
Closed
feat: add Hall effect, ADC, and encoder counter sensor classes#530ninankh wants to merge 5 commits into
ninankh wants to merge 5 commits into
Conversation
… encoder counter. Updated base sensor class accordingly
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the base sensor class along with three sensor driver implementations:
Unit tests are included for the base class and all three drivers.
Changes
base sensor class: shared interface/abstract methods used by the new sensor drivershall effect sensor: driver implementationadc sensor: driver implementationencoder counter sensor: driver implementationtests/Testing
make testlocally, all passingmake checkfor lint/format compliance