Skip to content

feat: add MaxonActuator brushed motor support - #533

Open
ninankh wants to merge 13 commits into
neurobionics:mainfrom
ninankh:vso_actuator_update
Open

feat: add MaxonActuator brushed motor support#533
ninankh wants to merge 13 commits into
neurobionics:mainfrom
ninankh:vso_actuator_update

Conversation

@ninankh

@ninankh ninankh commented Aug 14, 2026

Copy link
Copy Markdown

**Depends on #531 ** — this PR is built on top of that branch and includes its commits. Please review/merge #531 first; this diff will shrink to just the new changes once that's merged and this PR is retargeted to main.

Summary

Adds brushed motor support via a new MaxonActuator class, with the base
Actuator class updated to accommodate the brushed motor control interface.
Includes unit tests and a tutorial with sample usage code.

Changes

  • MaxonActuator: new brushed motor actuator implementation (H-bridge PWM control)
  • Actuator base class: updated to support brushed motor configuration
  • Unit tests added for MaxonActuator and updated base class behavior
  • Tutorial added under tutorials/ with sample code demonstrating homing and commanding motor position.

Testing

  • Added pytest coverage for MaxonActuator and affected base class paths
  • Ran make test locally, all passing
  • Ran make check for lint/format compliance
  • Manually verified tutorial sample code runs end-to-end

Checklist

  • Tests included for new functionality
  • Tutorial/docs added for new functionality

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.57456% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
opensourceleg/sensors/adc.py 98.3% 8 Missing and 1 partial ⚠️
opensourceleg/actuators/brushed.py 98.4% 2 Missing and 1 partial ⚠️
opensourceleg/sensors/hall.py 98.4% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants