Jan's MRI analysis - #12
Draft
valosekj wants to merge 22 commits into
Draft
Conversation
…es_between_y_true_and_y_pred
…true_and_y_pred' of github.com:SomeoneInParticular/modular_optuna_ml into jv/experimental-fix_different_num_of_classes_between_y_true_and_y_pred
This comment was marked as outdated.
This comment was marked as outdated.
valosekj
marked this pull request as ready for review
January 27, 2025 21:07
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…es_between_y_true_and_y_pred
This comment was marked as outdated.
This comment was marked as outdated.
valosekj
marked this pull request as draft
January 29, 2025 12:23
valosekj
added
the
experimental
valosekj
changed the title
…es_between_y_true_and_y_pred
To collect true binary labels and predicted probabilities for ROC curve generation
…y (validate)') to ROC figure fnames
SomeoneInParticular
left a comment
SomeoneInParticular
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the extreme delay on this, I swore I had submitted a review, but it seems it was pending this entire time
| 'UEMS_change_bin': 'UEMS Change', | ||
| 'LEMS_change_bin': 'LEMS Change', | ||
| 'AIS_change_bin_gt0': 'AIS Change' | ||
| } |
Collaborator
There was a problem hiding this comment.
We probably want to remove these hard-coded elements and move them to a CLI. I don't mind spinning one up as a proof-of-concept, but I don't have your data, so you'd have to validate that it still works on your data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental PR for my MRI analysis. Changes:
ValueError: y_true and y_pred contain different number of classesLogisticRegressionsolver tosagato make it work for RFE