Fix PhysX D6 translational limit lookup - #3569
Conversation
Read stiffness and damping from each translational axis's matching PhysxLimitAPI instance instead of the unrelated linear instance.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesPhysX D6 limit resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Fixes
SchemaResolverPhysxresolving all three D6 translational axes through the genericPhysxLimitAPI:linearinstance. EachtransX,transY, andtransZstiffness and damping value now comes from its matching multi-apply API instance.Checklist
CHANGELOG.mdhas been updated (if user-facing change)Test plan
Bug fix
Steps to reproduce:
PhysxLimitAPI:transX,PhysxLimitAPI:transY, andPhysxLimitAPI:transZ.limit_transX_ke,limit_transY_ke, orlimit_transZ_kewithSchemaResolverPhysx.PhysxLimitAPI:linearinstead of its corresponding axis.Minimal reproduction:
Summary by CodeRabbit