Fix deprecated example API usage - #3991
Conversation
Use example discovery as the CI coverage backstop while preserving tailored registrations. Require test_final() in test mode and document the contract. Temporarily allow existing deprecation warnings for five newly covered examples. A follow-up will migrate them and remove the allowances.
Migrate the five newly covered examples to supported APIs and remove their temporary strict-warning allowances. This restores deprecation enforcement for every auto-discovered example.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe example runner now requires callable ChangesExample testing and initialization
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized maintenance change removes deprecated example API usage and restores strict warning enforcement; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant TestSuite
participant newton.examples.init
participant ViewerGL
participant newton.examples.run
participant Example
TestSuite->>newton.examples.init: initialize example
newton.examples.init->>ViewerGL: show loading splash for visible viewer
TestSuite->>newton.examples.run: execute example
newton.examples.run->>ViewerGL: hide loading splash
newton.examples.run->>Example: call test_final() in test mode
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Follow-up to #3989. This PR must merge after #3989.
Migrate the five newly auto-discovered examples away from deprecated APIs and
remove their temporary strict-warning allowances. The examples now opt into
coordinate-layout joint targets where needed, the rigid-rigid VBD example uses
keyword arguments for
add_shape_box(), and the RJ45 example no longer authorsthe deprecated
vbd:joint_is_hardattribute, which has no solver-mode effectunder its existing compliant ALM configuration.
This restores strict deprecation-warning enforcement for every auto-discovered
example.
GitHub's native stacked pull requests require all branches to live in the same
repository. Because #3989 is a cross-fork PR, this dependent PR temporarily
targets
mainand includes the parent changes in its comparison. The follow-upchange itself is commit
a64ae9aa. After #3989 merges, this branch will berebased onto the updated
mainbefore this PR is marked ready.Checklist
Test plan
Before the migration, each of the five example commands failed with a
DeprecationWarningtreated as an error.Summary by CodeRabbit
Improvements
test_final()validation step.Bug Fixes
Tests