-
Notifications
You must be signed in to change notification settings - Fork 673
Allow usd-core 26.08 and adopt usd-exchange 3.x on aarch64 #4022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewkaufman
wants to merge
6
commits into
newton-physics:main
Choose a base branch
from
andrewkaufman:akaufman/usd-2608-allow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−58
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
10072f0
Allow usd-core 26.08 and adopt usd-exchange 3.x on aarch64
andrewkaufman d736e24
Only limit OpenUSD worker threads on runtimes with the collider-parsi…
andrewkaufman 6967301
Route the parser verification helper through the compat wrapper
andrewkaufman cd99399
Keep usd-exchange 2.3.0 installable on aarch64
andrewkaufman bec53ee
Merge branch 'main' into akaufman/usd-2608-allow
mzamoramora-nvidia 49fdb2a
Merge branch 'main' into akaufman/usd-2608-allow
andrewkaufman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Allow `usd-core` 26.08, and allow `usd-exchange` 3.x on aarch64 while keeping 2.3.0 installable, which extends USD support to Python 3.13 on aarch64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Stop forcing `PXR_WORK_THREAD_LIMIT=1` when running the test suite against OpenUSD 26.08 or newer, where the collider-parsing race it worked around is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🤖 get_repo_knowledge executed:
get_repo_knowledge newton-physics/newton /tmp/coderabbit-repo-knowledge/newton-physics-newton-69555c7f/learnings /tmp/coderabbit-repo-knowledge/newton-physics-newton-69555c7f/conventionsLength of output: 43905
🏁 Script executed:
Repository: newton-physics/newton
Length of output: 50377
🏁 Script executed:
Repository: newton-physics/newton
Length of output: 9034
Add focused tests for OpenUSD runtime detection.
Cover
usd-coreversions below and at 26.08,usd-exchangeextras for older and newer runtimes, missing metadata, and an existingPXR_WORK_THREAD_LIMIT. Keep detection before imports that can initializepxr. Runuv run --extra dev -m newton.tests.🤖 Prompt for AI Agents
Sources: Coding guidelines, Path instructions