Add asOverDog Kamino locomotion example - #4113
Conversation
Demonstrate Bennett, planar, and spherical overconstrained leg\nmechanisms with SolverKamino and DVI contact dynamics.\n\nRun the locomotion policy and learned actuator on the Warp device,\npace visualization at 50 Hz, and cover all variants with tests.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughAdded a Kamino ChangesasOverDog Kamino locomotion
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This PR adds a localized locomotion example and documentation without changing public APIs or introducing a concrete production risk; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant CommandInput
participant Example
participant ONNXPolicy
participant WarpKernels
participant SolverKamino
CommandInput->>Example: movement command or reset
Example->>WarpKernels: build observation
WarpKernels->>ONNXPolicy: observation tensor
ONNXPolicy->>WarpKernels: action tensor
WarpKernels->>SolverKamino: actuator forces and contact step
SolverKamino->>WarpKernels: updated state and loop anchors
WarpKernels->>Example: loop-closure error
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes implement the requested asOverDog example for Bennett, planar, and spherical variants. The example uses SolverKamino, robot-specific ONNX policies, learned actuation, multi-rate simulation, command input, CUDA Graph support, loop-closure validation, and stability checks. Tests, documentation, and a changelog entry are also included. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Closes #4112.
Add an asOverDog locomotion example for Bennett, planar, and spherical overconstrained closed-chain leg mechanisms.
The example:
--robot;SolverKaminoand DVI contact dynamics;--render-fpsoverride;Companion assets pull request: newton-physics/newton-assets#51
This PR is draft until the companion assets are merged. No public Newton APIs are added or changed.
Checklist
Test plan
The tests below were run against a local checkout of assets PR #51 exposed through the Newton asset cache.
New feature / API change
Summary by CodeRabbit
New Features
asOverDogquadruped simulation example supporting Bennett, planar, and spherical robot variants.Tests
Documentation