feat: ability to disable sync job by configuration - #13499
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Here I've added the ability to disable the syncronization job by settings
-1as value ofapp.mail.background-sync-interval.I've avoided to use
0as special value to avoid breaking existing behavior (which is: when 0, fallback to the default interval).I've not found better ways to disable the job "on demand". References I've found in other Nextcloud repositories (in files_antivirus and bookmarks) adopt all the same approach: just return from the
run()method if the condition of disabling is true.Fixes #10287