Skip to content

feat: ability to disable sync job by configuration - #13499

Open
madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:issue_10287
Open

feat: ability to disable sync job by configuration#13499
madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:issue_10287

Conversation

@madbob

@madbob madbob commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Here I've added the ability to disable the syncronization job by settings -1 as value of app.mail.background-sync-interval.
I've avoided to use 0 as special value to avoid breaking existing behavior (which is: when 0, fallback to the default interval).

I've not found better ways to disable the job "on demand". References I've found in other Nextcloud repositories (in files_antivirus and bookmarks) adopt all the same approach: just return from the run() method if the condition of disabling is true.

Fixes #10287

Signed-off-by: Roberto Guido <info@madbob.org>
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app.mail.background-sync-interval to 0

3 participants