Address review feedback on feed settings batch UI

Agent-Logs-Url: https://github.com/nextcloud/news/sessions/d85fd746-3df6-4c16-9600-1f0c048d0fcb

Co-authored-by: Grotax <5429298+Grotax@users.noreply.github.com>

Author: Copilot

CHANGELOG.md

@@ -7,10 +7,10 @@ You can also check [on GitHub](https://github.com/nextcloud/news/releases), the
 # Unreleased
 ### Added
 - Feed keyword filtering: hide articles matching keywords in title, body, or URL
+- Feed settings now supports selecting multiple feeds and moving/deleting them in throttled, sequential requests.
 
 ### Changed
 - Replace `arthurhoaro/favicon` with `php-feed-io/favicon-io` for favicon discovery, using PSR-based HTTP interfaces and Symfony-backed discovery caching (#3710)
-- Feed settings now supports selecting multiple feeds and moving/deleting them in throttled, sequential requests.
 
 ### Fixed
 

src/components/modals/FeedInfoTable.vue

@@ -119,6 +119,7 @@
 					:options="folderOptions"
 					:placeholder="t('news', 'Select folder')"
 					label="name"
+					trackBy="id"
 					:disabled="processingBatch"
 					:inputLabel="t('news', 'Select folder for selected feeds')"
 					class="batch-actions__select" />
@@ -159,6 +160,7 @@
 							<input
 								type="checkbox"
 								data-test="selectAllFeeds"
+								:aria-label="t('news', 'Select all feeds')"
 								:checked="allSelected"
 								:disabled="processingBatch || sortedFeeds.length === 0"
 								@change="toggleSelectAll">
@@ -245,6 +247,7 @@
 								type="checkbox"
 								:value="feed.id"
 								:disabled="processingBatch"
+								:aria-label="t('news', 'Select feed {feed}', { feed: feed.title || String(feed.id) })"
 								:data-test="'selectFeed-' + feed.id">
 						</td>
 						<td class="number">
@@ -422,7 +425,6 @@ export default {
 		TextShortIcon,
 		TextLongIcon,
 		FilterIcon,
-		NcButton,
 	},
 
 	emits: {
@@ -435,6 +437,7 @@ export default {
 			showMoveFeed: false,
 			selectedFeedIds: [],
 			batchMoveFolder: null,
+			noFolderOption: { id: 0, name: t('news', 'No folder') },
 			processingBatch: false,
 			batchRequestDelay: 150,
 			sortKey: 'title',
@@ -486,7 +489,7 @@ export default {
 		},
 
 		folderOptions() {
-			return [{ id: 0, name: t('news', 'No folder') }, ...this.folders]
+			return [this.noFolderOption, ...this.folders]
 		},
 
 		sortedFeeds() {

tests/javascript/unit/components/modals/FeedInfoTable.spec.ts

@@ -500,5 +500,6 @@ describe('FeedInfoTable.vue', () => {
 
 	afterEach(() => {
 		vi.restoreAllMocks()
+		vi.clearAllMocks()
 	})
 })