Repository navigation
Conversation
…ries A single line constraint and vertical gravity were lost for the note title TextView in 285e9b9, so long titles wrapped to a second line and overflowed the row bounds, appearing as ghost text underneath the first entry. AI-assistant: Cline Extension 1.x (GLM-5.3) Signed-off-by: Mark <mark-smirnow@yandex.ru>
Up to standards ✅🟢 Issues
|
| android:layout_weight="1" | ||
| android:layout_gravity="center_vertical" | ||
| android:gravity="center_vertical" | ||
| android:maxLines="1" |
There was a problem hiding this comment.
Hey @mark99i thanks for your PR!
This does improve the situation, but in case of long titles, the title is truncated and this is not visible to the user.
We could consider adding an ellipsize to make it clear:
| android:maxLines="1" | |
| android:maxLines="1" | |
| android:ellipsize="middle" |
I choose "middle" as it allows discerning between names like "Note 1", "Note 2"... and/or conflicted copies.
Before:
With your change:
After adding ellipsize:
There was a problem hiding this comment.
Personally, I think that the ellipsis takes up useful space and doesn’t look very good. But I’ll accept any decision. I was just curious about why the letters are leaking through.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
A single line constraint and vertical gravity were lost for the note title TextView in 285e9b9, so long titles wrapped to a second line and overflowed the row bounds, appearing as ghost text underneath the first entry.
AI-assistant: Cline Extension 1.x (GLM-5.3)
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)