fix: don't stop the entire share target repair on an error

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/files_sharing/lib/Repair/CleanupShareTarget.php

@@ -18,6 +18,7 @@
 use OCP\Migration\IOutput;
 use OCP\Migration\IRepairStep;
 use OCP\Share\IShare;
+use Psr\Log\LoggerInterface;
 
 /**
  * @psalm-type ShareInfo = array{id: string|int, share_type: string, share_with: string, file_source: string, file_target: string}
@@ -40,6 +41,7 @@ public function __construct(
 		private readonly SetupManager $setupManager,
 		private readonly IMountManager $mountManager,
 		private readonly IRootFolder $rootFolder,
+		private readonly LoggerInterface $logger,
 	) {
 	}
 
@@ -62,6 +64,9 @@ public function run(IOutput $output) {
 
 		foreach ($this->getProblemShares() as $shareInfo) {
 			$recipient = $this->userManager->getExistingUser($shareInfo['share_with']);
+			if (!$recipient->isEnabled()) {
+				continue;
+			}
 
 			// since we ordered the share by user, we can reuse the last data until we get to the next user
 			if ($lastUser !== $recipient->getUID()) {
@@ -78,20 +83,26 @@ public function run(IOutput $output) {
 			$absoluteNewTarget = $userFolder->getFullPath($newTarget);
 			$targetParentNode = $this->rootFolder->get(dirname($absoluteNewTarget));
 
-			$absoluteNewTarget = $this->shareTargetValidator->generateUniqueTarget(
-				(int)$shareInfo['file_source'],
-				$absoluteNewTarget,
-				$targetParentNode->getMountPoint(),
-				$userMounts,
-			);
-			$newTarget = $userFolder->getRelativePath($absoluteNewTarget);
-
-			$this->moveShare((string)$shareInfo['id'], $newTarget);
-
-			$oldMountPoint = "/{$recipient->getUID()}/files$oldTarget/";
-			$newMountPoint = "/{$recipient->getUID()}/files$newTarget/";
-			$userMounts[$newMountPoint] = $userMounts[$oldMountPoint];
-			unset($userMounts[$oldMountPoint]);
+			try {
+				$absoluteNewTarget = $this->shareTargetValidator->generateUniqueTarget(
+					(int)$shareInfo['file_source'],
+					$absoluteNewTarget,
+					$targetParentNode->getMountPoint(),
+					$userMounts,
+				);
+				$newTarget = $userFolder->getRelativePath($absoluteNewTarget);
+
+				$this->moveShare((string)$shareInfo['id'], $newTarget);
+
+				$oldMountPoint = "/{$recipient->getUID()}/files$oldTarget/";
+				$newMountPoint = "/{$recipient->getUID()}/files$newTarget/";
+				$userMounts[$newMountPoint] = $userMounts[$oldMountPoint];
+				unset($userMounts[$oldMountPoint]);
+			} catch (\Exception $e) {
+				$msg = 'error cleaning up share target: ' . $e->getMessage();
+				$this->logger->error($msg, ['exception' => $e, 'app' => 'files_sharing']);
+				$output->warning($msg);
+			}
 
 			$output->advance();
 		}