feat(files): bring back the Sidebar API - #63488
Merged
Merged
Conversation
1 task
susnux
added
enhancement
3. to review
susnux
marked this pull request as ready for review
August 22, 2026 17:46
susnux
requested review from
kristian-zendato and
sorbaugh
and removed request for
a team
August 22, 2026 17:46
CarlSchwan
approved these changes
Aug 24, 2026
CarlSchwan
left a comment
CarlSchwan
left a comment
Member
There was a problem hiding this comment.
nice this was also an issue in maps
Merged
Merged
Some apps have made use of the Files App Sidebar within their apps, like photots for example. This was dropped with Nextcloud 33 breaking those apps. Its not really feasible to implement the sidebar everytime the same, instead make it possible for apps to reuse the files sidebar again. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/sidebar-api
branch
from
September 19, 2026 17:28
90045b6 to
afd43be
Compare
The `files-main` and `files-sidebar` bundles both contain the sidebar modules, because the Webpack build only shares modules from `node_modules` between entry points. The data provider registered by the files app was therefore invisible to `initializeSidebar()` in the `files-sidebar` bundle, which rendered a second, standalone sidebar next to the one the files app already renders - so `#app-sidebar-vue` existed twice. Keep the data provider, the standalone provider and the mounted instance on `OCA.Files.Sidebar._sharedState` instead, so every entry point sees the same state - the same approach `getPinia()` already uses for the pinia instance. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
/backport to stable35 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some apps have made use of the Files App Sidebar within their apps, like photots for example.
This was dropped with Nextcloud 33 breaking those apps.
Its not really feasible to implement the sidebar everytime the same, instead make it possible for apps to reuse the files sidebar again.
Checklist
3. to review, feature component)stable32)AI (if applicable)