Repository navigation
Commit 1b16c71
committed
fix(ci): reinstall stale graph-ui node_modules in the license gate
License gate step 3/3 ran `npm ci` only when graph-ui/node_modules was
missing. Jenkins main build #32 (commit 2093ca0) reused a node_modules
tree left in the persistent workspace by build #31 (2026-10-06), which was
installed from a lockfile that predates the @types/node devDependency.
The install was skipped, `tsc -b` failed with TS2688 "Cannot find type
definition file for 'node'", and every later stage was skipped.
A stale tree is also a correctness problem for the gate itself: the npm
license check would inspect packages that are not the ones this candidate
ships.
The gate now reuses an existing tree only when `npm ls --all` confirms it
matches package.json and package-lock.json. Otherwise it runs
`npm ci --ignore-scripts`, which replaces the tree. A fresh `npm ci` of the
current lockfile passes `npm ls --all`, so a matching tree does not trigger
a reinstall on every run.
Since 9f26f16 the Jenkinsfile also cleans the workspace after each
build. This change keeps the gate correct for local runs and for any
workspace the cleanup misses.1 parent 2093ca0 commit 1b16c71
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
117 | 122 | | |
118 | 123 | | |
119 | 124 | | |
| |||
0 commit comments