Repository navigation
Commit 1f0daaa
committed
fix(mcp): keep DeusData#2134 root-owner reuse out of cross-repo mode; portable test path
Linux, MSan, TSan and diag CI failed in mcp_mutation_guard:
tool_cross_repo_missing_inputs_fail_without_creating_ghost_databases
ASSERT(source_failed). handle_index_repository resolved the root owner
before dispatching cross-repo-intelligence mode. That test registers its
named target with the source's own root, so the unindexed source adopted
existing-cross-target as its project (log: index.root_owner_reused
project=existing-cross-target), and the missing source was no longer
reported. Cross-repo mode reads an existing source index and never writes
one, so the DeusData#2134 reuse now runs only on the re-index path, after that
dispatch. macOS CI stayed green because cbm_tmpdir() is /tmp, a symlink
to /private/tmp there, so the canonical repo_path never equalled the
fixture's stored root; with the fixture path canonicalized, the failure
reproduced 3/3 on macOS and passes 3/3 with this change.
The DeusData#2134 test itself called realpath() into a 1 KiB buffer. glibc's
FORTIFY check aborts on that ("buffer overflow detected", a SIGABRT of the
mcp suite on the ubuntu 2/3 shards), and MinGW has no realpath at all
(Windows compile error). It now uses cbm_canonical_path with a 4 KiB
buffer, the same canonicalizer production uses.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent b94afb4 commit 1f0daaa
2 files changed
Lines changed: 18 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11517 | 11517 | | |
11518 | 11518 | | |
11519 | 11519 | | |
| 11520 | + | |
| 11521 | + | |
| 11522 | + | |
| 11523 | + | |
| 11524 | + | |
| 11525 | + | |
| 11526 | + | |
| 11527 | + | |
| 11528 | + | |
| 11529 | + | |
| 11530 | + | |
| 11531 | + | |
| 11532 | + | |
| 11533 | + | |
| 11534 | + | |
11520 | 11535 | | |
11521 | 11536 | | |
11522 | 11537 | | |
| |||
11534 | 11549 | | |
11535 | 11550 | | |
11536 | 11551 | | |
11537 | | - | |
11538 | | - | |
11539 | | - | |
11540 | | - | |
11541 | | - | |
11542 | | - | |
11543 | | - | |
11544 | | - | |
11545 | | - | |
11546 | | - | |
11547 | | - | |
11548 | | - | |
11549 | 11552 | | |
11550 | 11553 | | |
11551 | 11554 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8622 | 8622 | | |
8623 | 8623 | | |
8624 | 8624 | | |
8625 | | - | |
8626 | | - | |
8627 | | - | |
| 8625 | + | |
| 8626 | + | |
| 8627 | + | |
8628 | 8628 | | |
8629 | 8629 | | |
8630 | 8630 | | |
| |||
0 commit comments