Skip to content

Commit 359485b

Browse files
committed
fix(release): make the new CI scripts executable, and pin that they stay so
Every unix build leg of release run 30499236230 died during packaging: scripts/package-release.sh: line 190: scripts/ci/check-binary-composition.sh: Permission denied The composition gate was committed 100644 while being invoked as a command. It passed every local check because my WORKING COPY had the exec bit -- only the committed mode was wrong, and nothing you can run locally reveals that. scripts/ci/append-vt-notes.sh had the identical defect waiting in the verify step, the last step of the release, so this would have failed a second time after two hours of tests, build, smoke and soak. Fixed on BOTH sides, because either alone suffices and the pair is mode-proof: the two scripts are now 100755, and their call sites invoke them through `bash`, which is what most of this repo already does and which cannot break if a mode bit is ever lost to a patch application or a non-POSIX checkout. tests/test_script_exec_bit_contract.sh pins the class: any tracked .sh whose COMMITTED mode is non-executable must not appear as the first word of a command in workflows, scripts, test-infrastructure or the Makefiles. Verified in both directions -- it passes on this tree, and fails on the exact defect when the mode and the call site are reverted. It also joins backslash continuations before analysing, because its own first draft reported a false positive on ... && bash \ test-infrastructure/vm/vm-run-tests.sh --soak and a contract that cries wolf teaches people to ignore contracts. Product code is untouched: the test phase of the failed run was 27/27 green on this exact tree, and a file mode cannot change a test outcome. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent f0c65fb commit 359485b

2 files changed

File tree

‎scripts/ci/append-vt-notes.sh‎

100644100755
File mode changed.

‎scripts/ci/check-binary-composition.sh‎

100644100755
File mode changed.

0 commit comments

Comments
 (0)