Skip to content

Commit 497c680

Browse files
committed
fix(build): make the UI target depend on the generated integrations hash header
The -ui build failed on Windows with "cbm_integrations_hash.h file not found". integration_assets.c includes that generated header, and the subagent added it to PROJECT_HDRS so every single-invocation binary target picks it up — but cbm-with-ui is a phony target with its own direct recipe that does NOT list PROJECT_HDRS, so nothing generated the header before its one-shot compile. Only the UI variant hit this; the standard binary, test-runner, test-repro-runner and tsan targets all carry PROJECT_HDRS and built fine. Added $(INTEGRATIONS_HASH_HDR) as an explicit prerequisite of cbm-with-ui. Confirmed by dry-run: `make cbm-with-ui` now schedules the generator before the compile, and the header regenerates from clean. Audited every target that compiles integration_assets.c (via PROD_SRCS) — all now resolve the header, so this closes the build gap rather than moving it. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent d15bd72 commit 497c680

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎Makefile.cbm‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1057,7 +1057,11 @@ frontend:
10571057
embed: frontend
10581058
scripts/embed-frontend.sh graph-ui/dist $(BUILD_DIR)/embedded
10591059

1060-
cbm-with-ui: embed $(OBJS_VENDORED_PROD)
1060+
# $(INTEGRATIONS_HASH_HDR): generated header included by integration_assets.c.
1061+
# The standard target gets it via $(PROJECT_HDRS); the UI target compiles in one
1062+
# shot and must list it too, or the build fails with "cbm_integrations_hash.h
1063+
# file not found" (seen on the Windows UI build).
1064+
cbm-with-ui: embed $(INTEGRATIONS_HASH_HDR) $(OBJS_VENDORED_PROD)
10611065
$(CC) $(CFLAGS_PROD) -o $(BUILD_DIR)/codebase-memory-mcp \
10621066
$(MAIN_SRC) $(PROD_SRCS_WITH_ASSETS) \
10631067
$(EXTRACTION_SRCS) $(AC_LZ4_SRCS) $(ZSTD_SRCS) $(SQLITE_WRITER_SRC) \

0 commit comments

Comments
 (0)