Repository navigation
Commit 4b88690
committed
fix(mcp): give format:"json" the evidence columns it advertises (DeusData#1542)
`trace_path(include_evidence:true)` added `strategy` and `confidence` per hop in
the default tree output, and returned `cols: ["name","hop"]` under
format:"json" — no error, no warning, just two fields missing from the response
shape the schema and `--help` both promise.
include_evidence was only ever implemented in bfs_to_tree_table; bfs_to_tree_json
never took the flag. So the callers most likely to want the evidence — the ones
asking for structured output to consume programmatically — were exactly the ones
who silently got none of it. Reported by @asemraza.
The json path now emits both columns with the same semantics as the tree path,
including the placeholder case: the root hop has no inbound edge and non-CALLS
edges record no strategy, so those rows carry nulls rather than dropping fields
and leaving callers with ragged rows. Tree says "-", json says null — the same
promise in the form each consumer can test.
The existing evidence test covered only the tree path, which is why this went
unnoticed; it now asserts both formats.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent f3d78b1 commit 4b88690
2 files changed
Lines changed: 55 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6203 | 6203 | | |
6204 | 6204 | | |
6205 | 6205 | | |
6206 | | - | |
| 6206 | + | |
| 6207 | + | |
6207 | 6208 | | |
6208 | 6209 | | |
6209 | 6210 | | |
6210 | 6211 | | |
6211 | 6212 | | |
6212 | 6213 | | |
6213 | 6214 | | |
| 6215 | + | |
| 6216 | + | |
| 6217 | + | |
| 6218 | + | |
| 6219 | + | |
| 6220 | + | |
| 6221 | + | |
| 6222 | + | |
6214 | 6223 | | |
6215 | 6224 | | |
6216 | 6225 | | |
| |||
6258 | 6267 | | |
6259 | 6268 | | |
6260 | 6269 | | |
| 6270 | + | |
| 6271 | + | |
| 6272 | + | |
| 6273 | + | |
| 6274 | + | |
| 6275 | + | |
| 6276 | + | |
| 6277 | + | |
| 6278 | + | |
| 6279 | + | |
| 6280 | + | |
| 6281 | + | |
| 6282 | + | |
| 6283 | + | |
| 6284 | + | |
| 6285 | + | |
| 6286 | + | |
| 6287 | + | |
| 6288 | + | |
6261 | 6289 | | |
6262 | 6290 | | |
6263 | 6291 | | |
| |||
6710 | 6738 | | |
6711 | 6739 | | |
6712 | 6740 | | |
6713 | | - | |
6714 | | - | |
6715 | | - | |
| 6741 | + | |
| 6742 | + | |
| 6743 | + | |
6716 | 6744 | | |
6717 | 6745 | | |
6718 | 6746 | | |
6719 | | - | |
6720 | | - | |
6721 | | - | |
| 6747 | + | |
| 6748 | + | |
| 6749 | + | |
6722 | 6750 | | |
6723 | 6751 | | |
6724 | 6752 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3161 | 3161 | | |
3162 | 3162 | | |
3163 | 3163 | | |
| 3164 | + | |
| 3165 | + | |
| 3166 | + | |
| 3167 | + | |
| 3168 | + | |
| 3169 | + | |
| 3170 | + | |
| 3171 | + | |
| 3172 | + | |
| 3173 | + | |
| 3174 | + | |
| 3175 | + | |
| 3176 | + | |
| 3177 | + | |
| 3178 | + | |
| 3179 | + | |
| 3180 | + | |
| 3181 | + | |
| 3182 | + | |
| 3183 | + | |
3164 | 3184 | | |
3165 | 3185 | | |
3166 | 3186 | | |
| |||
0 commit comments