You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5fd1a07
Browse filesBrowse the repository at this point in the historyBrowse files
doc-links(cs): the type names of a refused scope are quarantined, in every run (R4)
A scope written in this run that the reader refuses costs its own file:
what its parse set is taken back and the file declares nothing. Other
files then found none of its declarations either: a reference to one of
its types was `missing`, or bound uniquely to another type of that name
which the full picture would not choose (a type of the enclosing namespace
comes before an imported one). Unplaced declarations are quarantined for
exactly this reason; a refused file's were not.
Now the type names the refused blob's T and Q records carry, read
leniently (a line counts when its name field is there and is a name,
however the rest of it reads), are quarantined, so a reference to one of
them from any file is a graph gap. The stored marker carries the same
names as Q records after its `!` record, so a later run that reads the
marker back quarantines them too and an incremental run equals a full one;
cs_scope_marked_rejected takes the marker followed only by Q records of
names. The resolver's rejected_scope is therefore a function of the
refused blob, and cbm_doclinks_storable_scope hands the marker to its
caller to free (lsp_surface.c).
One S8 expectation changes with this: Healthy.cs's reference to Hidden2,
a name Bad.cs declares where no namespace can be established (a Q record),
is now a graph gap rather than an edge -- as it is when Bad.cs's scope is
taken. The namespace checks of S8 (Shadow, Good.Lurker) are unchanged.
Test: cs_rejected_scope_contained and cs_rejected_scope_across_runs, whose
shared fixture gains Good.Widget in the refused file and Lib.Widget in an
imported namespace: Healthy.cs's Widget is a graph gap with no edge, and
the stored marker holds the five names.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
0 commit comments