Repository navigation
Commit 6a6229b
committed
fix(launcher): accept a trusted privileged owner on elevated installs
The launcher validated its own binary, staged payload, and their
directories with a strict "owner must be the exact token user" check
(launcher_security_is_private -> launcher_security_is_safe with
require_current_owner=true). On an elevated or managed install -- Program
Files, an admin-run installer, and GitHub's Windows runners -- the default
owner of newly created objects is BUILTIN\Administrators, not the calling
user, so the launcher rejected its own legitimately privileged-owned files
with "launcher ownership or access policy is unsafe [owner is not the
current user: S-1-5-32-544]" and refused to start.
Widen the owner check to the trusted-owner set that launcher_sid_is_trusted
already defines (self, SYSTEM, Administrators, TrustedInstaller) -- the same
set the daemon side applies for the identical default-owner reason. DACL
strictness is unchanged: every allow ACE must still grant only a trusted
identity, so tamper resistance is preserved; only the owner field is widened
to the privileged identities that manage the install. A less-privileged
attacker cannot stamp any of those owners without already holding that
privilege, so no real attack surface is added.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent fb54f54 commit 6a6229b
1 file changed
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
318 | | - | |
319 | | - | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
320 | 334 | | |
321 | 335 | | |
322 | 336 | | |
| |||
326 | 340 | | |
327 | 341 | | |
328 | 342 | | |
329 | | - | |
| 343 | + | |
330 | 344 | | |
331 | 345 | | |
332 | 346 | | |
| |||
344 | 358 | | |
345 | 359 | | |
346 | 360 | | |
347 | | - | |
| 361 | + | |
348 | 362 | | |
349 | 363 | | |
350 | 364 | | |
| |||
0 commit comments