@@ -22,8 +22,6 @@ def setUp(self):
2222 self .addCleanup (self .tmp .cleanup )
2323 self .ui = Path (self .tmp .name ) / "graph-ui"
2424 self .ui .mkdir ()
25- self .package ("@img/sharp-wasm32" , "0.35.0" ,
26- "Apache-2.0 AND LGPL-3.0-or-later AND MIT" )
2725 self .package ("@huggingface/transformers" , "4.2.0" , "Apache-2.0" )
2826 source = ROOT / "graph-ui/node_modules/@huggingface/transformers/dist/transformers.web.js"
2927 if not source .is_file ():
@@ -62,8 +60,7 @@ def setUp(self):
6260 }
6361 self .write_proof ()
6462 self .tree = {"dependencies" : {
65- "@huggingface/transformers" : {"version" : "4.2.0" , "dependencies" : {
66- "@img/sharp-wasm32" : {"version" : "0.35.0" }}}}}
63+ "@huggingface/transformers" : {"version" : "4.2.0" , "dependencies" : {}}}}
6764 self .bin = Path (self .tmp .name ) / "bin"
6865 self .bin .mkdir ()
6966 shim = self .bin / "npm.py"
@@ -72,13 +69,18 @@ def setUp(self):
7269 (self .bin / "npm" ).chmod (0o755 )
7370 (self .bin / "npm.cmd" ).write_text ('@python "%~dp0npm.py"\r \n ' )
7471
75- def package (self , name , version , license_id ):
72+ def package (self , name , version , license_id , ** platform ):
7673 folder = self .ui / "node_modules" / name
7774 folder .mkdir (parents = True )
7875 (folder / "package.json" ).write_text (json .dumps ({
79- "name" : name , "version" : version , "license" : license_id }))
76+ "name" : name , "version" : version , "license" : license_id , ** platform }))
8077 (folder / "LICENSE" ).write_text (license_id )
8178
79+ def add_transformers_dependency (self , name , version , license_id , ** platform ):
80+ self .package (name , version , license_id , ** platform )
81+ deps = self .tree ["dependencies" ]["@huggingface/transformers" ]["dependencies" ]
82+ deps [name ] = {"version" : version }
83+
8284 def write_proof (self ):
8385 path = self .ui / ".vite/license-build.json"
8486 path .parent .mkdir (exist_ok = True )
@@ -96,17 +98,41 @@ def assert_blocked(self):
9698 result = self .run_script ("license-gate-check-npm.py" )
9799 self .assertNotEqual (result .returncode , 0 , result .stdout + result .stderr )
98100
99- def test_verified_absent_package_does_not_block_browser_release (self ):
101+ def test_permissive_tree_with_verified_build_passes (self ):
100102 result = self .run_script ("license-gate-check-npm.py" )
101103 self .assertEqual (result .returncode , 0 , result .stdout + result .stderr )
102- self .assertIn ("@img/sharp-wasm32@0.35.0 " , result .stdout )
104+ self .assertIn ("all allow-listed " , result .stdout )
103105
104- def test_notices_use_the_same_shipped_package_decision (self ):
106+ def test_notices_cover_the_production_tree (self ):
105107 result = self .run_script ("gen-ui-licenses.py" )
106108 self .assertEqual (result .returncode , 0 , result .stdout + result .stderr )
107- self .assertNotIn ("### @img/sharp-wasm32@" , result .stdout )
108109 self .assertIn ("### @huggingface/transformers@4.2.0" , result .stdout )
109110
111+ def test_lgpl_package_blocks_even_when_unshipped (self ):
112+ # No exception for "installed but not bundled": sharp's wasm build
113+ # (LGPL libvips inside) once passed that way. It must block now.
114+ self .add_transformers_dependency ("@img/sharp-wasm32" , "0.35.0" ,
115+ "Apache-2.0 AND LGPL-3.0-or-later AND MIT" )
116+ result = self .run_script ("license-gate-check-npm.py" )
117+ self .assertNotEqual (result .returncode , 0 , result .stdout + result .stderr )
118+ self .assertIn ("@img/sharp-wasm32@0.35.0" , result .stdout )
119+
120+ def test_platform_restricted_lgpl_package_blocks (self ):
121+ # os/cpu-restricted native packages used to be skipped as build
122+ # tooling; that skip let all ten @img/sharp-libvips-* (LGPL) through.
123+ self .add_transformers_dependency ("@img/sharp-libvips-darwin-arm64" , "1.3.4" ,
124+ "LGPL-3.0-or-later" , os = ["darwin" ], cpu = ["arm64" ])
125+ result = self .run_script ("license-gate-check-npm.py" )
126+ self .assertNotEqual (result .returncode , 0 , result .stdout + result .stderr )
127+ self .assertIn ("@img/sharp-libvips-darwin-arm64@1.3.4" , result .stdout )
128+
129+ def test_platform_restricted_permissive_package_passes (self ):
130+ # Checking platform packages must not turn into blocking them.
131+ self .add_transformers_dependency ("@example/native-darwin-arm64" , "1.0.0" , "MIT" ,
132+ os = ["darwin" ], cpu = ["arm64" ])
133+ result = self .run_script ("license-gate-check-npm.py" )
134+ self .assertEqual (result .returncode , 0 , result .stdout + result .stderr )
135+
110136 def test_missing_proof_blocks (self ):
111137 (self .ui / ".vite/license-build.json" ).unlink ()
112138 self .assert_blocked ()
@@ -234,14 +260,6 @@ def test_unrelated_disallowed_dependency_still_blocks(self):
234260 self .tree ["dependencies" ]["unrelated" ] = {"version" : "1.0.0" }
235261 self .assert_blocked ()
236262
237- def test_new_package_version_requires_review (self ):
238- package = self .ui / "node_modules/@img/sharp-wasm32/package.json"
239- meta = json .loads (package .read_text ())
240- meta ["version" ] = "0.36.0"
241- package .write_text (json .dumps (meta ))
242- self .tree ["dependencies" ]["@huggingface/transformers" ]["dependencies" ]["@img/sharp-wasm32" ]["version" ] = "0.36.0"
243- self .assert_blocked ()
244-
245263
246264if __name__ == "__main__" :
247265 unittest .main ()
0 commit comments