Skip to content

Commit 71ac6ec

Browse files
committed
fix(mcp): reuse response cleanup in frontend worker
Signed-off-by: Pxx500 <pbartulik@gmail.com>
1 parent ca58149 commit 71ac6ec

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

‎src/daemon/frontend.c‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,12 @@ static bool frontend_recover_client(frontend_state_t *state, frontend_item_t *it
580580
return usable;
581581
}
582582

583+
static void frontend_response_reset(uint8_t **response, uint32_t *response_length) {
584+
free(*response);
585+
*response = NULL;
586+
*response_length = 0;
587+
}
588+
583589
static void *frontend_worker(void *opaque) {
584590
frontend_state_t *state = opaque;
585591
for (;;) {
@@ -606,9 +612,7 @@ static void *frontend_worker(void *opaque) {
606612
state->client, item.request_token, item.message, &response, &response_length,
607613
&request_sent, FRONTEND_REQUEST_TIMEOUT_MS);
608614
if (status == CBM_DAEMON_RUNTIME_APPLICATION_TRANSPORT_ERROR && !request_sent) {
609-
free(response);
610-
response = NULL;
611-
response_length = 0;
615+
frontend_response_reset(&response, &response_length);
612616
bool cancelled = false;
613617
if (frontend_recover_client(state, &item, &cancelled)) {
614618
if (cancelled) {
@@ -632,7 +636,7 @@ static void *frontend_worker(void *opaque) {
632636
item.content_length_framed);
633637
}
634638
}
635-
free(response);
639+
frontend_response_reset(&response, &response_length);
636640
bool expected_stop = failed && frontend_should_stop(state);
637641
frontend_end_request(state, failed && !expected_stop);
638642
frontend_item_free(&item);

0 commit comments

Comments
 (0)