Skip to content

Commit 7c51129

Browse files
committed
test(pipeline): DATA_FLOWS reach every caller and infra handler of a route
A route with 70 callers must link all 70 to its handler, a route whose INFRA_MAPS endpoint has 40 handlers must link its caller to all 40, and the flow set must not change when the callers' HTTP_CALLS edges are inserted in reverse order. Before the fix the first 64 callers and the first 32 infra handlers in insertion order were kept, so all three fail. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent 2a57f1d commit 7c51129

1 file changed

Lines changed: 95 additions & 0 deletions

File tree

‎tests/test_infrascan.c‎

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,98 @@ TEST(infrascan_http_calls_join_matching_handler_route) {
385385
PASS();
386386
}
387387

388+
/* FD16: a route's DATA_FLOWS were built from the first 64 callers and the first 32 infra handlers
389+
* in edge-insertion order (parallel worker interleaving), so the flow set changed between two
390+
* indexes of the same tree and every caller past the 64th lost its flow. */
391+
enum { FD16_CALLERS = 70, FD16_INFRA_HANDLERS = 40 };
392+
393+
static int64_t fd16_route_with_callers(cbm_gbuf_t *gb, int64_t *callers, bool reverse) {
394+
int64_t route = cbm_gbuf_upsert_node(gb, "Route", "/api/orders", "__route__GET__/api/orders",
395+
"", 0, 0, "{\"method\":\"GET\"}");
396+
int64_t handler = cbm_gbuf_upsert_node(gb, "Function", "get_orders", "test.get_orders",
397+
"server.py", 1, 3, "{}");
398+
cbm_gbuf_insert_edge(gb, handler, route, "HANDLES", "{\"handler\":\"test.get_orders\"}");
399+
for (int i = 0; i < FD16_CALLERS; i++) {
400+
char name[32];
401+
char qn[48];
402+
snprintf(name, sizeof(name), "client_%02d", i);
403+
snprintf(qn, sizeof(qn), "test.client_%02d", i);
404+
callers[i] =
405+
cbm_gbuf_upsert_node(gb, "Function", name, qn, "client.py", i + 1, i + 1, "{}");
406+
}
407+
for (int k = 0; k < FD16_CALLERS; k++) {
408+
int i = reverse ? FD16_CALLERS - 1 - k : k;
409+
cbm_gbuf_insert_edge(gb, callers[i], route, "HTTP_CALLS",
410+
"{\"callee\":\"requests.get\",\"url_path\":\"/api/orders\","
411+
"\"method\":\"GET\"}");
412+
}
413+
return handler;
414+
}
415+
416+
TEST(infrascan_data_flows_link_every_caller_of_a_route) {
417+
cbm_gbuf_t *gb = cbm_gbuf_new("test", "/tmp/cbm_infrascan_fd16_callers");
418+
ASSERT_NOT_NULL(gb);
419+
int64_t callers[FD16_CALLERS];
420+
int64_t handler = fd16_route_with_callers(gb, callers, false);
421+
cbm_pipeline_create_route_nodes(gb);
422+
for (int i = 0; i < FD16_CALLERS; i++) {
423+
ASSERT_TRUE(has_data_flow(gb, callers[i], handler));
424+
}
425+
cbm_gbuf_free(gb);
426+
PASS();
427+
}
428+
429+
TEST(infrascan_data_flows_do_not_depend_on_caller_insertion_order) {
430+
cbm_gbuf_t *fwd = cbm_gbuf_new("test", "/tmp/cbm_infrascan_fd16_fwd");
431+
cbm_gbuf_t *rev = cbm_gbuf_new("test", "/tmp/cbm_infrascan_fd16_rev");
432+
ASSERT_NOT_NULL(fwd);
433+
ASSERT_NOT_NULL(rev);
434+
int64_t fwd_callers[FD16_CALLERS];
435+
int64_t rev_callers[FD16_CALLERS];
436+
int64_t fwd_handler = fd16_route_with_callers(fwd, fwd_callers, false);
437+
int64_t rev_handler = fd16_route_with_callers(rev, rev_callers, true);
438+
cbm_pipeline_create_route_nodes(fwd);
439+
cbm_pipeline_create_route_nodes(rev);
440+
for (int i = 0; i < FD16_CALLERS; i++) {
441+
ASSERT_EQ(has_data_flow(fwd, fwd_callers[i], fwd_handler),
442+
has_data_flow(rev, rev_callers[i], rev_handler));
443+
}
444+
cbm_gbuf_free(fwd);
445+
cbm_gbuf_free(rev);
446+
PASS();
447+
}
448+
449+
TEST(infrascan_data_flows_reach_every_infra_handler) {
450+
cbm_gbuf_t *gb = cbm_gbuf_new("test", "/tmp/cbm_infrascan_fd16_infra");
451+
ASSERT_NOT_NULL(gb);
452+
int64_t route = cbm_gbuf_upsert_node(gb, "Route", "/api/orders", "__route__GET__/api/orders",
453+
"", 0, 0, "{\"method\":\"GET\"}");
454+
int64_t endpoint = cbm_gbuf_upsert_node(gb, "Route", "/orders", "__route__GET__/orders", "", 0,
455+
0, "{\"method\":\"GET\"}");
456+
int64_t client =
457+
cbm_gbuf_upsert_node(gb, "Function", "client", "test.client", "client.py", 1, 3, "{}");
458+
cbm_gbuf_insert_edge(gb, route, endpoint, "INFRA_MAPS", "{}");
459+
cbm_gbuf_insert_edge(gb, client, route, "HTTP_CALLS",
460+
"{\"callee\":\"requests.get\",\"url_path\":\"/api/orders\","
461+
"\"method\":\"GET\"}");
462+
int64_t handlers[FD16_INFRA_HANDLERS];
463+
for (int i = 0; i < FD16_INFRA_HANDLERS; i++) {
464+
char name[32];
465+
char qn[48];
466+
snprintf(name, sizeof(name), "orders_%02d", i);
467+
snprintf(qn, sizeof(qn), "test.orders_%02d", i);
468+
handlers[i] =
469+
cbm_gbuf_upsert_node(gb, "Function", name, qn, "server.py", i + 1, i + 1, "{}");
470+
cbm_gbuf_insert_edge(gb, handlers[i], endpoint, "HANDLES", "{}");
471+
}
472+
cbm_pipeline_create_route_nodes(gb);
473+
for (int i = 0; i < FD16_INFRA_HANDLERS; i++) {
474+
ASSERT_TRUE(has_data_flow(gb, client, handlers[i]));
475+
}
476+
cbm_gbuf_free(gb);
477+
PASS();
478+
}
479+
388480
SUITE(infrascan) {
389481
RUN_TEST(infrascan_http_route_literal_guard_rejects_filesystem_paths);
390482
RUN_TEST(infrascan_http_route_literal_guard_rejects_document_extensions);
@@ -393,4 +485,7 @@ SUITE(infrascan) {
393485
RUN_TEST(infrascan_service_pattern_match_keeps_real_library_qns);
394486
RUN_TEST(infrascan_route_nodes_skip_bad_http_url_paths);
395487
RUN_TEST(infrascan_http_calls_join_matching_handler_route);
488+
RUN_TEST(infrascan_data_flows_link_every_caller_of_a_route);
489+
RUN_TEST(infrascan_data_flows_do_not_depend_on_caller_insertion_order);
490+
RUN_TEST(infrascan_data_flows_reach_every_infra_handler);
396491
}

0 commit comments

Comments
 (0)