Repository navigation
Commit 8182026
committed
fix(pipeline): run the external-import guard after route classification
The DeusData#1355 guard dropped the call before the emitters ran, so it did not
only remove the fabricated CALLS edge it is meant to remove: it also
skipped the route, HTTP, CONFIG and URL classification that happens inside
emit_classified_edge / emit_service_edge. A PR that claims to touch nothing
but weak same-name CALLS edges was silently costing Route nodes, and with
them every HANDLES edge that pass_route_nodes.c later bridges onto those
routes.
The shape is not hypothetical. A route registration whose router is a
dependency is exactly a bare call bound by a package specifier: the
resolved QN carries the router library name, emit_classified_edge reads it
as CBM_SVC_ROUTE_REG, and the first argument is path-shaped. On a
66-file TypeScript fixture main mints __route__ANY__/orders and the guard
removed it, on both resolvers.
The fix is the seam the DeusData#592/DeusData#606 member guard already uses, for the same
reason and with the same comment: join the predicate to drop_plain_call and
let the emitter decide. Only the plain-CALLS fall-through is suppressed, so
the fabricated edge still goes and every service edge stays main-identical.
The two resolvers keep identical gates, as the notes in both files require.
The new pipeline test asserts both halves on both resolvers: the Route node
survives, and a second bare call from the same external package in the same
file is still cut, so the first assertion cannot pass by the guard having
been disarmed.
Signed-off-by: Yyunozor <yyunozor@icloud.com>1 parent 138a622 commit 8182026
3 files changed
Lines changed: 131 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
634 | 634 | | |
635 | 635 | | |
636 | 636 | | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
637 | 646 | | |
638 | 647 | | |
639 | 648 | | |
640 | | - | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
641 | 653 | | |
642 | 654 | | |
643 | 655 | | |
| |||
669 | 681 | | |
670 | 682 | | |
671 | 683 | | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
676 | | - | |
677 | | - | |
678 | | - | |
679 | | - | |
680 | | - | |
681 | | - | |
682 | 684 | | |
683 | 685 | | |
684 | 686 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2499 | 2499 | | |
2500 | 2500 | | |
2501 | 2501 | | |
| 2502 | + | |
| 2503 | + | |
| 2504 | + | |
| 2505 | + | |
| 2506 | + | |
2502 | 2507 | | |
2503 | 2508 | | |
2504 | 2509 | | |
2505 | | - | |
| 2510 | + | |
| 2511 | + | |
| 2512 | + | |
| 2513 | + | |
2506 | 2514 | | |
2507 | 2515 | | |
2508 | 2516 | | |
| |||
2573 | 2581 | | |
2574 | 2582 | | |
2575 | 2583 | | |
2576 | | - | |
2577 | | - | |
2578 | | - | |
2579 | | - | |
2580 | | - | |
2581 | | - | |
2582 | | - | |
2583 | | - | |
2584 | | - | |
2585 | 2584 | | |
2586 | 2585 | | |
2587 | 2586 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5348 | 5348 | | |
5349 | 5349 | | |
5350 | 5350 | | |
| 5351 | + | |
| 5352 | + | |
| 5353 | + | |
| 5354 | + | |
| 5355 | + | |
| 5356 | + | |
| 5357 | + | |
| 5358 | + | |
| 5359 | + | |
| 5360 | + | |
| 5361 | + | |
| 5362 | + | |
| 5363 | + | |
| 5364 | + | |
| 5365 | + | |
| 5366 | + | |
| 5367 | + | |
| 5368 | + | |
| 5369 | + | |
| 5370 | + | |
| 5371 | + | |
| 5372 | + | |
| 5373 | + | |
| 5374 | + | |
| 5375 | + | |
| 5376 | + | |
| 5377 | + | |
| 5378 | + | |
| 5379 | + | |
| 5380 | + | |
| 5381 | + | |
| 5382 | + | |
| 5383 | + | |
| 5384 | + | |
| 5385 | + | |
| 5386 | + | |
| 5387 | + | |
| 5388 | + | |
| 5389 | + | |
| 5390 | + | |
| 5391 | + | |
| 5392 | + | |
| 5393 | + | |
| 5394 | + | |
| 5395 | + | |
| 5396 | + | |
| 5397 | + | |
| 5398 | + | |
| 5399 | + | |
| 5400 | + | |
| 5401 | + | |
| 5402 | + | |
| 5403 | + | |
| 5404 | + | |
| 5405 | + | |
| 5406 | + | |
| 5407 | + | |
| 5408 | + | |
| 5409 | + | |
| 5410 | + | |
| 5411 | + | |
| 5412 | + | |
| 5413 | + | |
| 5414 | + | |
| 5415 | + | |
| 5416 | + | |
| 5417 | + | |
| 5418 | + | |
| 5419 | + | |
| 5420 | + | |
| 5421 | + | |
| 5422 | + | |
| 5423 | + | |
| 5424 | + | |
| 5425 | + | |
| 5426 | + | |
| 5427 | + | |
| 5428 | + | |
| 5429 | + | |
| 5430 | + | |
| 5431 | + | |
| 5432 | + | |
| 5433 | + | |
| 5434 | + | |
| 5435 | + | |
| 5436 | + | |
| 5437 | + | |
| 5438 | + | |
| 5439 | + | |
| 5440 | + | |
| 5441 | + | |
| 5442 | + | |
| 5443 | + | |
| 5444 | + | |
| 5445 | + | |
| 5446 | + | |
| 5447 | + | |
| 5448 | + | |
| 5449 | + | |
| 5450 | + | |
| 5451 | + | |
| 5452 | + | |
| 5453 | + | |
| 5454 | + | |
| 5455 | + | |
| 5456 | + | |
| 5457 | + | |
| 5458 | + | |
5351 | 5459 | | |
5352 | 5460 | | |
5353 | 5461 | | |
| |||
13699 | 13807 | | |
13700 | 13808 | | |
13701 | 13809 | | |
| 13810 | + | |
13702 | 13811 | | |
13703 | 13812 | | |
13704 | 13813 | | |
| |||
0 commit comments