Skip to content

Commit 85a086e

Browse files
authored
Merge pull request DeusData#1269 from DeusData/fix/stale-never-close
fix(stale): mark awaiting-reporter issues stale, never auto-close
2 parents 1a66f70 + 8831603 commit 85a086e

1 file changed

Lines changed: 27 additions & 10 deletions

File tree

‎.github/workflows/stale.yml‎

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,24 @@
11
name: Stale awaiting-reporter
22

3+
# Marks inactive `awaiting-reporter` issues as `stale`. It NEVER closes them:
4+
# closing an issue as "not planned" is a maintainer judgement, not an automated
5+
# one, so this workflow only surfaces a review queue and a human decides.
6+
#
37
# Only touches issues that a maintainer has explicitly marked `awaiting-reporter`.
48
# Never touches pull requests, and never touches issues without that label.
59
# A reporter comment removes `stale` and resets the clock.
10+
#
11+
# WHY never close (2026-07-26): `awaiting-reporter` is applied by hand and means
12+
# "the reporter owes the next step". It was also being used to mean "we will come
13+
# back to this", which is a different thing. In that second case the automation was
14+
# closing issues the project itself owed work on — #56 was a confirmed bug with an
15+
# in-tree reproduction (tests/repro/repro_issue56.c, landed via #667) queued to close
16+
# as `not_planned` purely because a maintainer had the last word. A mislabel should
17+
# cost a stale tag, never a silently discarded bug.
18+
#
19+
# The `stale` label is therefore a review queue, not a countdown. Sweep it during
20+
# triage: clear the label where we owe the next step, and close by hand where the
21+
# thread is genuinely dead.
622

723
on:
824
schedule:
@@ -23,22 +39,23 @@ jobs:
2339
only-labels: 'awaiting-reporter'
2440
stale-issue-label: 'stale'
2541
days-before-issue-stale: 21
26-
days-before-issue-close: 14
42+
# -1 disables automated closing entirely. Marking stale is the whole job.
43+
days-before-issue-close: -1
2744
# Never act on pull requests with this workflow.
2845
days-before-pr-stale: -1
2946
days-before-pr-close: -1
47+
# Belt-and-braces: these categories must never be auto-flagged even if
48+
# `awaiting-reporter` is applied to them by mistake. `task` covers the
49+
# umbrella/epic issues (incl. the pinned roadmap index #595), and
50+
# `maintainer-notes` is the explicit "we owe the next step" escape hatch.
51+
exempt-issue-labels: 'security,task,maintainer-notes'
3052
remove-stale-when-updated: true
31-
close-issue-reason: not_planned
3253
operations-per-run: 60
3354
ascending: true
3455
stale-issue-message: >
3556
This issue has been waiting on more information for 21 days (a
3657
version, exact steps, or a public repro), so it's now marked
37-
`stale`. It will be closed in 14 days if there's no update — just
38-
add a comment to keep it open. We're happy to pick it back up the
39-
moment we can reproduce it.
40-
close-issue-message: >
41-
Closing because we haven't received the requested details and can't
42-
reproduce it as-is. This isn't a "won't fix" — please comment with
43-
the info (version + a public repro) and we'll reopen and dig in.
44-
Thanks for the report.
58+
`stale`. **It will not be closed automatically** — a maintainer
59+
reviews stale issues by hand. Adding a comment with the details
60+
clears the label and puts it straight back in the queue. We're happy
61+
to pick it back up the moment we can reproduce it.

0 commit comments

Comments
 (0)