You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 87cafb9
Browse filesBrowse the repository at this point in the historyBrowse files
fix(extract): bump the index format for receiver-qualified Go method QNs
Review follow-up for DeusData#1913 (asks from the 2026-09-28 review), plus one
finding from the review of the updated head:
- store.h: CBM_INDEX_FORMAT_VERSION 3 -> 4. Every Go method QN changes
(pkg.method -> pkg.Recv.method), so an index built before this change
and refreshed incrementally would mix flat and receiver-qualified
method nodes, with the old fused nodes keeping their stale edges. The
bump routes such an index through one full rebuild.
- pipeline_go_method_caller_keeps_lsp_join: the by-name assertion would
also pass for a binding onto the decoy other.Decoy.helper. The test now
pins the edge by QN suffix on both ends (.svc.Repo.Install ->
.svc.Repo.helper) with an lsp_* strategy, and asserts no edge to the
decoy.
- extract_defs.c: the receiver-qualified def QN is Go-only. The templ
grammar is Go-derived and reaches the same receiver branch, but its
call-scope QN (compute_func_qn) stays flat, so a templ method would get
a def QN no call names and its calls would degrade to the File node.
extract_templ_method_qn_matches_call_scope pins def QN == call scope.
- pass_semantic.c: the check_go_class_implements comment no longer
describes Go method QNs as flat.
Refs DeusData#1909
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
0 commit comments