Repository navigation
Commit 8b4e0fb
committed
fix(windows): accept the OWNER RIGHTS (S-1-3-4) ACE in DACL validation
The guards cache-dir rejection, once its SID was printed, was the
OWNER RIGHTS well-known SID S-1-3-4: an ACE that modulates the rights
granted to whoever OWNS the object. Both the daemon
(win_bounded_sid_trusted) and the launcher (launcher_bounded_ace_sid_
is_trusted) validate the owner separately as the exact current user, so
an OWNER RIGHTS ACE can only ever grant to us - it is safe. Default
Windows profile/temp ACLs (and GitHub runner profiles) carry it, and
rejecting it locked the daemon and launcher out of legitimate
current-user directories (three green guards went red: non-ascii path,
non-ascii cache dump, windows launcher). Accept WinCreatorOwnerRightsSid
in both bounded-ACE checks. Real-user Windows fix, not just CI.
mingw-cross-compiled clean.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent 897aa7a commit 8b4e0fb
2 files changed
Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3875 | 3875 | | |
3876 | 3876 | | |
3877 | 3877 | | |
3878 | | - | |
| 3878 | + | |
| 3879 | + | |
| 3880 | + | |
| 3881 | + | |
| 3882 | + | |
| 3883 | + | |
| 3884 | + | |
3879 | 3885 | | |
3880 | 3886 | | |
3881 | 3887 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
231 | | - | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
232 | 236 | | |
233 | 237 | | |
234 | 238 | | |
| |||
0 commit comments