Skip to content

Commit 8cd2ee5

Browse files
halindromeclaude
andcommitted
fix(daemon): address QA round 4
Reflow the host-loop seam call to clang-format and note that the fixture's convenience start joins its own participant guard, unlike the host's start_reserved. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NbYKGdU7pqG6AEuMQuJxiF Signed-off-by: Shane McCarron <shane.mccarron@corvexconnect.com>
1 parent b15e7f9 commit 8cd2ee5

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

‎tests/test_daemon_runtime.c‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1272,7 +1272,8 @@ typedef struct {
12721272

12731273
/* When set, the fixture takes the host's coordination handles in the host's
12741274
* order before starting the service: cohort admission refuses once a
1275-
* generation is already serving. */
1275+
* generation is already serving. Unlike the host's start_reserved, the
1276+
* fixture's convenience start also joins a service-owned participant guard. */
12761277
static runtime_test_coordination_t *runtime_test_fixture_coordination = NULL;
12771278

12781279
static bool runtime_test_fixture_start_configured(
@@ -1452,9 +1453,9 @@ TEST(daemon_runtime_host_loop_stops_on_coordination_file_loss) {
14521453
CBMLogLevel previous_log_level = cbm_log_get_level();
14531454
cbm_log_set_level(CBM_LOG_INFO);
14541455
cbm_log_set_sink(runtime_test_lifetime_log_sink);
1455-
loop_ok = cbm_daemon_host_wait_for_lifetime_for_test(
1456-
fixture.service, fixture.endpoint, coordination.lease, coordination.claim,
1457-
coordination.guard);
1456+
loop_ok = cbm_daemon_host_wait_for_lifetime_for_test(fixture.service, fixture.endpoint,
1457+
coordination.lease, coordination.claim,
1458+
coordination.guard);
14581459
cbm_log_set_sink(NULL);
14591460
cbm_log_set_level(previous_log_level);
14601461
}

0 commit comments

Comments
 (0)