Repository navigation
Commit 928191b
committed
fix: resolve PR #18 CodeRabbit minor and nitpick comments
CodeRabbit's PR #18 review bodies listed 17 minor and 4 nitpick comments.
Each was checked against the current code. 20 are fixed and 1 is skipped.
Behaviour fixes:
- cypher.c: selective-end pattern planning no longer reorders patterns
under RETURN *, so star projection keeps the order the query wrote.
Covered by an extended cypher_single_hop_seeds_from_selective_far_node.
- cli.c: the BUSY activation state now returns ACTIVE and goes through the
normal coordinated reservation path.
- changes.c: after budget trimming, the changed, module and impacted
sections each report the right higher-budget continuation hint. The
impacted-row prefix is found by binary search, not one row at a time.
- pass_pkgmap.c: local_name is JSON-escaped before it is matched against
serialized import properties.
- watcher.c: the retry backoff deadline comes from a fresh monotonic
timestamp taken at failure time and saturates at INT64_MAX.
- cbm.c: cbm_line_is_inert treats only '#' as a first-character
comment/directive marker, not '*'.
- helpers.c: capacity growth starts at 16 from zero and switches to the
requested size before integer doubling could overflow.
- pass_parallel.c: the system-pressure query runs only when spilling is
available.
Naming and docs (fork binary is codebase-memory-cli):
- docs/CONFIGURATION.md default cache path
- daemon conflict hint in runtime.c, with MCP config wording replaced
- memwaste.sh and memwaste-scaling.py driver binary name
- CONTRIBUTING.md names this fork's maintainer
Scripts and test harnesses:
- soak-test.sh exits when runtime init fails.
- memlab-report.py diffs profile sites by resolved symbol.
- test_git_env_isolation_contract.sh tolerates a log with no passed line
under pipefail.
- test_shell_line_endings.sh keeps its source-archive fallback reachable.
- test_daemon_application.c gates the host session on prior setup.
- test_mem_events.c clears the forced-tracking flag after the suite.
- test_helpers.h reuses the production cbm_git_repo_env_vars list.
Skipped: "do not raise memory-core baseline limits". The cited counts are
already in the base commit, match current measurements, and the ratchet
passes.
Validated:
- -Werror build and test-runner
- lint --ci
- cypher, daemon_application, integration, parse_coverage, mem_events and
parallel suites
- both shell contract scripts run directly1 parent 8758668 commit 928191b
21 files changed
Lines changed: 117 additions & 62 deletions
File tree
- docs
- internal/cbm
- scripts
- src
- cli
- cypher
- daemon
- operations
- pipeline
- watcher
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
| 167 | + | |
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1490 | 1490 | | |
1491 | 1491 | | |
1492 | 1492 | | |
1493 | | - | |
| 1493 | + | |
1494 | 1494 | | |
1495 | 1495 | | |
1496 | 1496 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
645 | 645 | | |
646 | 646 | | |
647 | 647 | | |
648 | | - | |
| 648 | + | |
649 | 649 | | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
650 | 654 | | |
651 | 655 | | |
652 | 656 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
| 156 | + | |
156 | 157 | | |
157 | | - | |
158 | | - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
159 | 166 | | |
160 | 167 | | |
161 | 168 | | |
162 | 169 | | |
163 | 170 | | |
164 | 171 | | |
165 | | - | |
| 172 | + | |
166 | 173 | | |
167 | 174 | | |
168 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
629 | 629 | | |
630 | 630 | | |
631 | 631 | | |
632 | | - | |
633 | | - | |
| 632 | + | |
634 | 633 | | |
635 | 634 | | |
636 | 635 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5205 | 5205 | | |
5206 | 5206 | | |
5207 | 5207 | | |
5208 | | - | |
| 5208 | + | |
| 5209 | + | |
5209 | 5210 | | |
5210 | 5211 | | |
5211 | 5212 | | |
| |||
0 commit comments