Repository navigation
Commit a2242e1
committed
test(test-impact): the Git fixture waits for Git, no quiet timeout decides
The Git facts fixture ran every Git command with a 10 s quiet timeout. The
diff-driver controls run `git diff --ext-diff` / `--textconv` with a fresh
copy of the test runner as the driver; on a loaded host that copy takes over
10 s to start and finish, Git prints nothing meanwhile, and the timeout killed
it (outcome HANG). test-windows (x86_64) failed
test_git_ancestor_changes_history_and_external_driver_guards_apply that way
(controls[0]), and locally 12 concurrent runs of that test failed 8 times,
every failure HANG at ~10,020 ms. Without the quiet timeout the same run
failed 0 of 12.
The fixture now waits for Git to finish; the suite's own ceiling stays the
backstop. No fixture caller expects a hang.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent 962d5b9 commit a2242e1
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
123 | 128 | | |
124 | 129 | | |
125 | 130 | | |
126 | 131 | | |
127 | | - | |
128 | | - | |
| 132 | + | |
129 | 133 | | |
130 | 134 | | |
131 | 135 | | |
| |||
0 commit comments