Skip to content

Commit a50f97c

Browse files
committed
fix(smoke): serve the -portable linux asset from the artifact server
The dry-run smoke Phase 14 runs the binary's real `update` command, which on linux downloads the fully-static "-portable" asset (build_update_url in src/cli/cli.c appends -portable on linux; _build.yml's build-linux-portable job ships codebase-memory-mcp[-ui]-linux-<arch>-portable.tar.gz). The smoke artifact server only served the non-portable name, so `update` 404'd and the config- refresh assertion failed on every linux smoke leg. The mismatch (the smoke half of the -portable delivery change) was masked until every smoke leg became a required gate. Mirror the tarball under the -portable name on linux (standard and ui) so the served names match build_update_url; checksums.txt globs *.tar.gz and picks up the new files. Verified the fixed logic serves the exact name the binary requests for both variants; the gating smoke Phase 14 is the regression guard. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent a5351d3 commit a50f97c

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

‎.github/workflows/_smoke.yml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,19 @@ jobs:
114114
cp "/tmp/smoke-server/codebase-memory-mcp${SUFFIX}-${OS}-${ARCH}.tar.gz" \
115115
"/tmp/smoke-server/codebase-memory-mcp-${OS}-${ARCH}.tar.gz"
116116
fi
117+
# The linux binary self-updates from the fully-static "-portable" asset
118+
# (build_update_url in src/cli/cli.c appends -portable on linux; _build.yml's
119+
# build-linux-portable job ships it), so the smoke server must serve that name
120+
# too -- otherwise `update` 404s and Phase 14 fails. Mirror the tarball(s) under
121+
# the -portable name on linux only.
122+
if [ "$OS" = "linux" ]; then
123+
cp "/tmp/smoke-server/codebase-memory-mcp${SUFFIX}-${OS}-${ARCH}.tar.gz" \
124+
"/tmp/smoke-server/codebase-memory-mcp${SUFFIX}-${OS}-${ARCH}-portable.tar.gz"
125+
if [ -n "$SUFFIX" ]; then
126+
cp "/tmp/smoke-server/codebase-memory-mcp${SUFFIX}-${OS}-${ARCH}-portable.tar.gz" \
127+
"/tmp/smoke-server/codebase-memory-mcp-${OS}-${ARCH}-portable.tar.gz"
128+
fi
129+
fi
117130
cd /tmp/smoke-server
118131
sha256sum *.tar.gz > checksums.txt 2>/dev/null || shasum -a 256 *.tar.gz > checksums.txt
119132
python3 -m http.server 18080 -d /tmp/smoke-server &

0 commit comments

Comments
 (0)