|
16 | 16 | * test_non_ascii_path.py guards #636/#357 (fixed by #700) |
17 | 17 | * test_hook_augment.py guards #618 (fixed by #619) |
18 | 18 | * test_ui_drive_listing.py guards #548 (roots field) |
| 19 | + * test_cli_non_ascii_arg.py guards #423/#20 (wide-argv main()) |
19 | 20 |
|
20 | 21 | KNOWN REDS - genuine, still-open Windows bugs reproduced at the product |
21 | 22 | surface. They are EXPECTED to be RED (exit 1) and are opt-in |
22 | 23 | (never gate CI). If one turns GREEN the underlying bug was |
23 | 24 | fixed and it should be promoted to a guard. |
24 | | - * test_cli_non_ascii_arg.py reproduces #423/#20 (narrow |
25 | | - argv main() - no wide command line) |
| 25 | + * (none currently - test_cli_non_ascii_arg.py was promoted to a |
| 26 | + guard when the wide-argv fix for #423/#20 landed) |
26 | 27 |
|
27 | | - Determinism: indexing runs in-process (CBM_INDEX_SUPERVISOR=0). These tests |
28 | | - exercise path / hook / drive handling, not the index-supervisor subprocess |
29 | | - path; the pass-level readers (#700's cbm_fopen routing) run in-process either |
30 | | - way, so the guard coverage is identical while results stay independent of the |
31 | | - local toolchain's worker-spawn behavior. |
| 28 | + Determinism: the runner sets CBM_INDEX_SUPERVISOR=0 so the path / hook / drive |
| 29 | + guards index in-process (the pass-level readers under test, e.g. #700's cbm_fopen |
| 30 | + routing, run in-process either way). The non-ASCII CLI guard is the exception - it |
| 31 | + drops that override to cross the real supervisor -> worker spawn, where the second |
| 32 | + half of #423/#20 lives (CreateProcessW delivering the wide command line). |
32 | 33 |
|
33 | 34 | On native Windows the MinGW/LLVM toolchain ships no libasan/libubsan, so the |
34 | 35 | build disables sanitizers (SANITIZE=). Where the toolchain provides |
@@ -104,14 +105,14 @@ $env:CBM_INDEX_SUPERVISOR = "0" # in-process indexing (see .DESCRIPTION) |
104 | 105 | $guards = @( |
105 | 106 | "tests\windows\test_non_ascii_path.py", |
106 | 107 | "tests\windows\test_hook_augment.py", |
107 | | - "tests\windows\test_ui_drive_listing.py" |
108 | | -) |
109 | | - |
110 | | -# Opt-in known-red repros - EXPECTED red (exit 1); never gate CI. |
111 | | -$knownReds = @( |
| 108 | + "tests\windows\test_ui_drive_listing.py", |
112 | 109 | "tests\windows\test_cli_non_ascii_arg.py" |
113 | 110 | ) |
114 | 111 |
|
| 112 | +# Opt-in known-red repros - EXPECTED red (exit 1); never gate CI. Currently empty: |
| 113 | +# test_cli_non_ascii_arg.py was promoted to a guard when #423/#20's wide-argv fix landed. |
| 114 | +$knownReds = @() |
| 115 | + |
115 | 116 | $guardFailures = @() |
116 | 117 | $guardSkips = @() |
117 | 118 | $fixedKeepers = @() |
@@ -159,7 +160,7 @@ if ($fixedKeepers.Count -gt 0) { |
159 | 160 | } |
160 | 161 | if ($guardFailures.Count -gt 0) { |
161 | 162 | Write-Host ("REGRESSION: {0} green guard(s) went red: {1}" -f $guardFailures.Count, ($guardFailures -join ", ")) -ForegroundColor Red |
162 | | - Write-Host "A previously-fixed Windows bug is broken again. See tests/windows/RED_TEST_ANALYSIS.md." -ForegroundColor Red |
| 163 | + Write-Host "A previously-fixed Windows bug is broken again (see the guard's docstring and its referenced issue)." -ForegroundColor Red |
163 | 164 | exit 1 |
164 | 165 | } |
165 | 166 | Write-Host "All Windows green guards passed." -ForegroundColor Green |
|
0 commit comments