Repository navigation
Commit a8293c4
committed
fix: address review feedback on external-import-shadow guard
- specifier_is_relative() now also recognizes Windows drive-letter
(C:\ / C:/) and UNC (\\server\share) specifiers as in-tree, not
external packages. pr-smoke runs this pipeline on Windows, and the
previous POSIX-only check ('.' / '/') classified those specifiers as
external, which could suppress a real edge on that platform only.
Added external_import_shadow_windows_relative_specifier_kept
(tests/test_registry.c): red before this fix, green after.
- old_workers / old_single in the DeusData#1355 pipeline test are now
const char*, matching getenv()'s read-only contract.
- The pad_files literal (50) is now a named
EXTERNAL_IMPORT_SHADOW_PARALLEL_PAD constant with a comment tying it
to MIN_FILES_FOR_PARALLEL (a private #define in pipeline.c, not
reachable for a static_assert from tests), so a future bump to that
threshold can't silently drop the fixture back onto the
sequential-only path.
Signed-off-by: Yyunozor <yyunozor@icloud.com>1 parent eaf5904 commit a8293c4
3 files changed
Lines changed: 73 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
502 | 503 | | |
503 | 504 | | |
504 | 505 | | |
505 | | - | |
506 | | - | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
507 | 512 | | |
508 | | - | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
509 | 529 | | |
510 | 530 | | |
511 | 531 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4976 | 4976 | | |
4977 | 4977 | | |
4978 | 4978 | | |
| 4979 | + | |
| 4980 | + | |
| 4981 | + | |
| 4982 | + | |
| 4983 | + | |
| 4984 | + | |
| 4985 | + | |
| 4986 | + | |
| 4987 | + | |
| 4988 | + | |
| 4989 | + | |
4979 | 4990 | | |
4980 | 4991 | | |
4981 | 4992 | | |
| |||
5066 | 5077 | | |
5067 | 5078 | | |
5068 | 5079 | | |
5069 | | - | |
| 5080 | + | |
5070 | 5081 | | |
5071 | | - | |
| 5082 | + | |
| 5083 | + | |
| 5084 | + | |
5072 | 5085 | | |
5073 | | - | |
| 5086 | + | |
5074 | 5087 | | |
5075 | 5088 | | |
5076 | 5089 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1059 | 1059 | | |
1060 | 1060 | | |
1061 | 1061 | | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
1062 | 1095 | | |
1063 | 1096 | | |
1064 | 1097 | | |
| |||
1161 | 1194 | | |
1162 | 1195 | | |
1163 | 1196 | | |
| 1197 | + | |
1164 | 1198 | | |
0 commit comments