Repository navigation
Commit ba529c9
committed
doc-links(cs): a props or targets file that does not parse up to its root is unknown (R6)
The project-file scan wrote the "could not be read" blob for a *.csproj
that is no readable MSBuild <Project>, and for a *.props or *.targets file
only once its <Project> root was seen. A *.props or *.targets file that is
malformed before its root, or ends before one, got no blob at all: an
import of it counted as outside the repository with a closed scope, and as
the nearest Directory.Build.* it was passed over for the one above, whose
usings were then applied although MSBuild does not read that file.
Such a file now gets the "could not be read" blob too, so the projects that
evaluate it have an open scope. A *.props or *.targets file whose root
element is not <Project> is still no MSBuild file and has no blob.
Test: msbuild_malformed_props_opens (a malformed nearest
Directory.Build.props under a usable one: a name found nowhere is external,
and a type only the upper file's using reaches is not bound; decoy: a
project without a nearer file binds through the upper file and keeps a
closed scope).
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent d77ce46 commit ba529c9
2 files changed
Lines changed: 50 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3707 | 3707 | | |
3708 | 3708 | | |
3709 | 3709 | | |
3710 | | - | |
3711 | | - | |
| 3710 | + | |
| 3711 | + | |
3712 | 3712 | | |
3713 | 3713 | | |
3714 | 3714 | | |
| |||
3719 | 3719 | | |
3720 | 3720 | | |
3721 | 3721 | | |
| 3722 | + | |
3722 | 3723 | | |
3723 | 3724 | | |
3724 | 3725 | | |
| |||
3751 | 3752 | | |
3752 | 3753 | | |
3753 | 3754 | | |
| 3755 | + | |
3754 | 3756 | | |
3755 | 3757 | | |
3756 | 3758 | | |
| |||
3762 | 3764 | | |
3763 | 3765 | | |
3764 | 3766 | | |
3765 | | - | |
| 3767 | + | |
| 3768 | + | |
| 3769 | + | |
| 3770 | + | |
| 3771 | + | |
| 3772 | + | |
3766 | 3773 | | |
3767 | 3774 | | |
3768 | 3775 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9698 | 9698 | | |
9699 | 9699 | | |
9700 | 9700 | | |
| 9701 | + | |
| 9702 | + | |
| 9703 | + | |
| 9704 | + | |
| 9705 | + | |
| 9706 | + | |
| 9707 | + | |
| 9708 | + | |
| 9709 | + | |
| 9710 | + | |
| 9711 | + | |
| 9712 | + | |
| 9713 | + | |
| 9714 | + | |
| 9715 | + | |
| 9716 | + | |
| 9717 | + | |
| 9718 | + | |
| 9719 | + | |
| 9720 | + | |
| 9721 | + | |
| 9722 | + | |
| 9723 | + | |
| 9724 | + | |
| 9725 | + | |
| 9726 | + | |
| 9727 | + | |
| 9728 | + | |
| 9729 | + | |
| 9730 | + | |
| 9731 | + | |
| 9732 | + | |
| 9733 | + | |
| 9734 | + | |
| 9735 | + | |
| 9736 | + | |
| 9737 | + | |
| 9738 | + | |
| 9739 | + | |
9701 | 9740 | | |
9702 | 9741 | | |
9703 | 9742 | | |
| |||
10275 | 10314 | | |
10276 | 10315 | | |
10277 | 10316 | | |
| 10317 | + | |
10278 | 10318 | | |
10279 | 10319 | | |
10280 | 10320 | | |
| |||
0 commit comments