Skip to content

Commit c3b3569

Browse files
committed
fix(soak): resolve the .exe whenever it exists, not only when -x fails
Both hosted-runner Windows soak legs failed at Phase 1/diagnostics with an empty frontend stderr while the daemon's own log showed a healthy diagnostics.start: the workflows pass the suffix-less binary path, msys resolves it transparently (so the old 'append .exe only when the plain name is not executable' branch never fired), and soak-test keys BOTH native-Windows gates — the cygpath'd CBM_CACHE_DIR and the coproc stdio branch — off the literal .exe suffix. A suffix-less native binary therefore received a POSIX-form cache path: daemon logs mis-rooted (diagnostics grep zero, arm64) and the frontend's cache path handling died silently (x64 SIGPIPE at first write). Reproduced on the VM's CLANG64 environment with a suffix-less invocation (same FAIL) and red->green proven: with the normalization the identical invocation runs the full quick soak to PASSED. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent 7973f1a commit c3b3569

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

‎scripts/soak-legs.sh‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,14 @@ esac
6767
[ "$DURATION" -gt 0 ] || { echo "soak-legs: duration must be positive" >&2; exit 2; }
6868
# Windows builds produce <name>.exe; resolve it here so every venue passes the
6969
# same plain path and carries no per-platform binary-name logic of its own.
70-
if [ ! -x "$BINARY" ] && [ -x "${BINARY}.exe" ]; then
70+
# Resolve whenever the .exe EXISTS, not only when the plain name fails -x:
71+
# msys resolves the suffix-less name transparently (it IS -x), but soak-test
72+
# keys its native-Windows handling — cygpath'd CBM_CACHE_DIR, coproc stdio —
73+
# off the literal .exe suffix. A suffix-less native binary therefore received
74+
# a POSIX-form cache path, mis-rooting the daemon logs and silently disabling
75+
# diagnostics (both hosted-runner Windows soak legs; reproduced on the VM's
76+
# CLANG64 environment with a suffix-less invocation).
77+
if [[ "$BINARY" != *.exe ]] && [ -x "${BINARY}.exe" ]; then
7178
BINARY="${BINARY}.exe"
7279
fi
7380
[ -x "$BINARY" ] || { echo "soak-legs: binary '$BINARY' missing or not executable — build first" >&2; exit 2; }

0 commit comments

Comments
 (0)