Skip to content

Commit c400dc1

Browse files
committed
ci: hosted runners cannot enable Defender RTP — revert runner-side gating
Dry run 30225685743 failed at the ensure-defender step on every Windows job: the hosted images policy-lock real-time protection OFF (WinDefend starts, Set-MpPreference accepts, RTP stays off — untamperable from the job). Revert to the pre-gate runner behavior: no ensure-defender step in runner jobs, the release Defender scan is on-demand and fail-soft again. The local VM preflight KEEPS the fail-closed Defender-ON gate (same canonical script) — AV-interaction coverage is a deliberate local superset where the platform allows it. The venue-parity contract now enforces the INVERSE for runners (ensure-defender must not gate hosted jobs) and still requires the VM preflight gate; VM README documents the verified posture delta. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent def6984 commit c400dc1

12 files changed

Lines changed: 2585 additions & 53 deletions

File tree

‎.github/workflows/_smoke.yml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,6 @@ jobs:
172172
steps:
173173
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
174174

175-
- name: Ensure Windows Defender is active (venue parity)
176-
shell: pwsh
177-
run: scripts/ci/ensure-defender.ps1
178-
179175
- uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2
180176
with:
181177
msystem: ${{ matrix.arch == 'arm64' && 'CLANGARM64' || 'CLANG64' }}
@@ -258,9 +254,7 @@ jobs:
258254
if ($code -eq 2) {
259255
Write-Host "BLOCKED: Windows Defender flagged $binary!"; exit 1
260256
} elseif ($code -ne 0) {
261-
# ensure-defender gates this job earlier, so the engine MUST be
262-
# available here: an engine failure is a red gate, never a skip.
263-
Write-Host "BLOCKED: Defender scan engine could not run for $binary (exit $code) - Defender-ON parity violated"; exit 1
257+
Write-Host "::warning::Windows Defender scan could not run for $binary (exit $code) - skipping AV gate on this runner"
264258
} else {
265259
Write-Host "=== Windows Defender: $binary clean ==="
266260
}

‎.github/workflows/_soak.yml‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,6 @@ jobs:
9393
steps:
9494
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
9595

96-
- name: Ensure Windows Defender is active (venue parity)
97-
shell: pwsh
98-
run: scripts/ci/ensure-defender.ps1
9996
- uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2
10097
with:
10198
msystem: CLANG64
@@ -153,9 +150,6 @@ jobs:
153150
steps:
154151
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
155152

156-
- name: Ensure Windows Defender is active (venue parity)
157-
shell: pwsh
158-
run: scripts/ci/ensure-defender.ps1
159153
- uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2
160154
with:
161155
msystem: CLANGARM64
@@ -271,9 +265,6 @@ jobs:
271265
steps:
272266
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
273267

274-
- name: Ensure Windows Defender is active (venue parity)
275-
shell: pwsh
276-
run: scripts/ci/ensure-defender.ps1
277268
- uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2
278269
with:
279270
msystem: CLANG64

‎.github/workflows/_test.yml‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -247,11 +247,12 @@ jobs:
247247
steps:
248248
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
249249

250-
# Defender parity: every Windows venue (local VM and runner alike) tests
251-
# with real-time protection ACTIVE — enabled + verified, never skipped.
252-
- name: Ensure Windows Defender is active (venue parity)
253-
shell: pwsh
254-
run: scripts/ci/ensure-defender.ps1
250+
# Defender posture: real-time protection is POLICY-LOCKED OFF on hosted
251+
# Windows images (verified 2026-07-27: WinDefend starts and
252+
# Set-MpPreference accepts, but RTP stays off — untamperable from the
253+
# job). The local VM leg enforces Defender-ON via the canonical Defender
254+
# preflight script, so AV-interaction coverage lives there; runners run
255+
# without RTP by platform constraint.
255256

256257
- uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2
257258
with:
@@ -381,10 +382,6 @@ jobs:
381382
steps:
382383
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
383384

384-
- name: Ensure Windows Defender is active (venue parity)
385-
shell: pwsh
386-
run: scripts/ci/ensure-defender.ps1
387-
388385
- uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2
389386
with:
390387
msystem: CLANG64

‎.github/workflows/pr.yml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,6 @@ jobs:
8484
steps:
8585
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
8686

87-
- name: Ensure Windows Defender is active (venue parity)
88-
if: matrix.os == 'windows-latest'
89-
shell: pwsh
90-
run: scripts/ci/ensure-defender.ps1
91-
9287
- name: Install deps (Ubuntu)
9388
if: matrix.os == 'ubuntu-latest'
9489
run: sudo apt-get update && sudo apt-get install -y zlib1g-dev ccache

‎soak-results-query-leak/cbm-daemon.log‎

Lines changed: 1413 additions & 0 deletions
Large diffs are not rendered by default.

‎soak-results-query-leak/cli-churn-stderr.log‎

Lines changed: 120 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)