Repository navigation
Commit c828105
committed
fix(extract): write C variants in graph_buffer's schema
Main's graph_buffer.c ("Definition variants") records a definition's
variant spans as [{"file_path","start_line","end_line"}], and the
test-impact engine reads that schema to find every TEST(...) branch of one
test. This branch's extractor wrote [{"start","end"}]. On the merge with
main, graph_buffer's same-QN merge found a non-empty variants list it could
not read and dropped every span, the definition's own included. The engine
then no longer found the second #if branch of TEST(alpha_uses_lib), so
test_impact_engine_variant_tests_are_one_test reported suite alpha
UNMAPPED, in CI on macOS and Windows and locally.
The extractor now writes the shared schema, with the file path
JSON-escaped. The C-preprocessor-only gate and the one-carrier rule are
unchanged, and the variants assertions use the shared format.
test_impact_engine, extraction, pipeline, graph_buffer and
conditional_variants: 857 passed.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent c4d6453 commit c828105
4 files changed
Lines changed: 40 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
2165 | 2167 | | |
2166 | 2168 | | |
2167 | 2169 | | |
2168 | | - | |
| 2170 | + | |
| 2171 | + | |
| 2172 | + | |
2169 | 2173 | | |
2170 | 2174 | | |
2171 | 2175 | | |
| |||
2175 | 2179 | | |
2176 | 2180 | | |
2177 | 2181 | | |
2178 | | - | |
| 2182 | + | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
| 2186 | + | |
| 2187 | + | |
| 2188 | + | |
| 2189 | + | |
| 2190 | + | |
| 2191 | + | |
| 2192 | + | |
2179 | 2193 | | |
2180 | 2194 | | |
2181 | 2195 | | |
| |||
2186 | 2200 | | |
2187 | 2201 | | |
2188 | 2202 | | |
2189 | | - | |
2190 | | - | |
| 2203 | + | |
| 2204 | + | |
| 2205 | + | |
| 2206 | + | |
| 2207 | + | |
2191 | 2208 | | |
2192 | 2209 | | |
2193 | 2210 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
274 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
275 | 277 | | |
276 | 278 | | |
277 | 279 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7743 | 7743 | | |
7744 | 7744 | | |
7745 | 7745 | | |
7746 | | - | |
| 7746 | + | |
| 7747 | + | |
7747 | 7748 | | |
7748 | 7749 | | |
7749 | 7750 | | |
7750 | 7751 | | |
7751 | 7752 | | |
7752 | 7753 | | |
7753 | | - | |
7754 | | - | |
| 7754 | + | |
| 7755 | + | |
| 7756 | + | |
| 7757 | + | |
7755 | 7758 | | |
7756 | 7759 | | |
7757 | 7760 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10536 | 10536 | | |
10537 | 10537 | | |
10538 | 10538 | | |
10539 | | - | |
10540 | | - | |
10541 | | - | |
| 10539 | + | |
| 10540 | + | |
| 10541 | + | |
| 10542 | + | |
| 10543 | + | |
| 10544 | + | |
10542 | 10545 | | |
10543 | 10546 | | |
10544 | 10547 | | |
| |||
10680 | 10683 | | |
10681 | 10684 | | |
10682 | 10685 | | |
10683 | | - | |
10684 | | - | |
| 10686 | + | |
| 10687 | + | |
| 10688 | + | |
| 10689 | + | |
10685 | 10690 | | |
10686 | 10691 | | |
10687 | 10692 | | |
| |||
0 commit comments