Skip to content

Commit d8b5419

Browse files
committed
docs: record batched Jev review and source correction requirements
1 parent aed13e0 commit d8b5419

3 files changed

Lines changed: 93 additions & 0 deletions

File tree

‎BACKLOG.md‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,3 +182,17 @@
182182
- Next path: inspect the saved Heaptrack allocation call trees; only add
183183
teardown code for allocations proven to be owned by the neutral daemon
184184
rather than allocator or test-process lifetime state.
185+
186+
- [ ] Complete DeepSeek Phase1 independent source review. All115 assignments and
187+
342 evidence-manifest entries pass integrity checks; six bounded semantic
188+
questions were reviewed in three batched Jev requests. Documentary result is
189+
changes requested: narrow runtime `9724d903046626df0640ced218259cb58070e4e8`
190+
committed-counter/budget claim, preserve operations
191+
`b04f54506ab42eddcbd89232a0d47d8355edd596` mechanism remainder and
192+
`f6afd6138e605365a76d065d04521ec2037bed3d` title-policy question, and classify
193+
integration `00411ce7bc41995783bfb16aada673515585446d` changed Linux alias
194+
behavior as missing. Other109 hashes remain independently unreviewed; integration
195+
29 partial rows plus1 unresolved row require function-level work. Exact hashes,
196+
requests, full distributions and source corrections are in the canonical308 review
197+
section and consolidated report; machine crosswalk stays handoff evidence. No
198+
completion/acceptance or semantic-closure counter advanced.

‎docs/UPSTREAM_308_CANDIDATE_AUDIT_20260912.md‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1973,3 +1973,33 @@ retained in run evidence.
19731973
| `fa2292111802b5f3b66db3e4dd168280b53ac17e` | excluded | mixed_shared_scope_unresolved; artifact-export-attribution |
19741974
| `fcf451c6a6dda768dfec5a8f61a01ac1e1cfa6bf` | deferred | semantic_unresolved; native-merge:c7488b031ce95a517ca91dac1df6ddab30718189 |
19751975
| `ff8dd47011c43c622d3dc82b33be32b4493e4ea9` | excluded | semantic_unresolved; native-merge:5df8b0442c48fed654c6f11d94cb6f64f00fc368 |
1976+
1977+
### DeepSeek Phase1 independent review — 2026-10-03 UTC
1978+
1979+
All three Herdr workers are idle with saved dispositions matching their exact
1980+
39/26/50 assignments. Parent verified all115 assignment sets, all cited evidence
1981+
links and342 manifest entries. Three Jev requests batched six bounded primary-source
1982+
questions using jev-1.13.0; worker verdicts and earlier Jev answers were excluded.
1983+
The [consolidated review](UPSTREAM_RECONCILIATION_REPORT_20261002.md#deepseek-phase1-review-with-batched-jev-advice--2026-10-03-utc)
1984+
records full distributions, exact source reasons and required continuation.
1985+
Documentary disposition is **changes requested**, not acceptance or a host review gate.
1986+
1987+
Runtime `9724d903046626df0640ced218259cb58070e4e8` needs a narrower diagnostics
1988+
claim: normal Linux budget pressure reads OS RSS, not the committed counter.
1989+
Operations `b04f54506ab42eddcbd89232a0d47d8355edd596` remains property-level
1990+
partial, with changed refinement caller/mechanism unresolved;
1991+
`f6afd6138e605365a76d065d04521ec2037bed3d` retains the neutral CLI title-policy question.
1992+
Integration `00411ce7bc41995783bfb16aada673515585446d` has missing changed Linux
1993+
alias/ordinary-directory continuation behavior in all three frozen CLI targets.
1994+
Bounded exclusions for `d70b79417978a9f3ab0d1aa849879dbf049793cf` and
1995+
`8f3c15044b8200a15ee1895c5127f4bf117da493` apply only at their exact absent seams.
1996+
These sampled judgments do not approve other16 integration exclusions.
1997+
1998+
Six commits have bounded independent semantic review; other109 full hashes are
1999+
explicitly independently unreviewed in
2000+
`CBM-DEEPSEEK-JEV-REVIEW-20261003/review-crosswalk.jsonl` under handoff evidence.
2001+
Integration admits incomplete function-level reading for29 partial rows and1
2002+
unresolved row; operations retains four remainders. Runtime finish requires host
2003+
verification binding; operations/integration finished partial. Worker completion,
2004+
source comparison, review, Jenkins validation, acceptance and integration remain
2005+
separate. No whole-commit closure counter is advanced by this bounded review.

‎docs/UPSTREAM_RECONCILIATION_REPORT_20261002.md‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,3 +458,52 @@ evidence and unresolved hunks are retained with each raw record in run evidence.
458458
| `6db22aadb6e5a92b9b193608e2ac3f420e461ec3` | represented | VB6 marker detection, .frm/.cls disambiguation to unsupported, and regressions are present in production and both QA. |
459459
| `a953509275a4fa42a907f88852d62a613f27bc56` | partially represented | Core error-range cap/dropped-marker and parse_unusable behavior (including ObjectScript range aggregation and parallel/serial phase storage) are absent from production and both QA. MCP-only coverage wording/serialization is excluded from CLI semantic counts. |
460460
| `21591d51168d26f931f64d62edc36013cd1f6249` | partially represented | The decisive arithmetic differs: production and both QA targets return aggregate_memory_budget_bytes / physical_job_limit despite computing and logging active job count. Frozen upstream returns aggregate_memory_budget_bytes / active, where active comes from nonterminal jobs and has a floor of one. Thus symbol presence, active_jobs logging, and the shared helper do not establish parity. The upstream merge plan explicitly lists this hash as divide by active jobs rather than configured capacity and assigns daemon_application,daemon suites. The commit also adds a sequenced two-job regression for aggregate then half-aggregate slices and a test that a clean worker over-budget error passes through without a recovery retry; neither test name is in production/QA. Do not infer the separately assigned Windows job-memory-resolution change from this hash. |
461+
462+
## DeepSeek Phase1 review with batched Jev advice — 2026-10-03 UTC
463+
464+
Review disposition: **changes requested**. This is documentary parent review evidence; no host acceptance/rejection or Agent-Workflow review gate is invoked.
465+
466+
All 115 assignments match their disposition sets exactly, with no duplicate rows or missing evidence links. All 342 worker-manifest entries verify (runtime113, operations86, integration143). Independent Git diffs were captured for all115; capturing a diff is not semantic review.
467+
468+
Three official-helper API calls batch two questions each. Requests contain verbatim governing requirements, exact commit diffs, frozen source excerpts, and deterministic integrity output. Worker verdicts, worker summaries, previous Jev answers and credential values were excluded. Token sourced silently; destination verified https://api.typesafe.ai. SDK used in an isolated offline-cached uv runtime; no project install, build/test or Jenkins execution.
469+
470+
Six full-hash commits received bounded source review; other109 remain explicitly independently unreviewed in review-crosswalk.jsonl. No worker rows are silently changed or counted as accepted.
471+
472+
### Findings
473+
474+
- Runtime: 9724d903046626df0640ced218259cb58070e4e8 lacks committed/peak-counter guards in target diagnostics, but its claim that the normal Linux budget path reads the committed counter is too broad. Frozen target src/foundation/mem.c cbm_mem_over_budget:511-515 calls cbm_mem_rss, whose Linux branch reads OS /proc RSS first. Keep missing diagnostics adaptation and upstream-only heap-switch applicability distinct. No runtime failure reproduced.
475+
- Runtime: d70b79417978a9f3ab0d1aa849879dbf049793cf changes internal/cbm/result_spill.c, absent in all frozen CLI targets. Bounded seam exclusion is supportable for this exact MSan guard; surrounding shared memory work remains separate.
476+
- Operations: b04f54506ab42eddcbd89232a0d47d8355edd596 is not closed by table-lookup property similarity. Target internal/cbm/cbm.c:1129-1300 builds offsets for cbm_subtract_macro_invocation_regions; upstream diff optimizes cbm_refine_regions_with_pp_lines and supplies allocation fallback. Exact changed caller/refinement mechanism remains unresolved.
477+
- Operations: f6afd6138e605365a76d065d04521ec2037bed3d removes MCP title accessor and changes the upstream generated Pi label. Target src/operations/tool_catalog.c retains cbm_tool_catalog_title. No governing CLI title-removal policy supplied: exclude direct MCP edits, keep the neutral policy question unresolved.
478+
- Integration: 00411ce7bc41995783bfb16aada673515585446d should be recorded as **missing changed Linux alias behavior**, not merely partly represented because surrounding security functions exist. Target activation_posix_walk_path is Apple-only and returns NULL for non-symlink aliases; upstream admits Linux and /home and continues for ordinary directories. All three frozen CLI targets have the same relevant pre-change behavior.
479+
- Integration: 8f3c15044b8200a15ee1895c5127f4bf117da493 can be excluded at the direct generated-OpenCode-plugin seam: target install branch emits instructions/skills, generator file/call is absent. This does not approve all16 excluded integration rows or establish broader OpenCode parity.
480+
481+
### Jev results and decision effects
482+
483+
| Batch / question | Model | Choice | Full probability distribution | Advice effect |
484+
|---|---|---|---|---|
485+
| runtime / counter_guard_scope | jev-1.13.0 | diagnostics_only (confidence 0.43) | diagnostics_only=0.58, represented=0.34, budget_and_diagnostics=0.07, insufficient=0.01 | Narrow 9724d903 to missing diagnostics/allocator wrap guard adaptation; normal Linux budget pressure is OS-RSS based. No reproduced runtime defect. Do not import upstream heap switch by default. |
486+
| runtime / spill_exclusion | jev-1.13.0 | excluded (confidence 0.75) | insufficient=0.05, shared_missing=0.12, excluded=0.83 | Bounded exclusion for this exact internal/cbm/result_spill.c MSan guard; not a verdict on adjoining neutral memory commits. |
487+
| ops / table_optimization_equivalence | jev-1.13.0 | partial_property (confidence 0.53) | whole_represented=0.34, insufficient=0.00, partial_property=0.66, missing=0.00 | Do not promote property-level representation to whole-commit closure. Target region subtraction and upstream per-line preprocessor refinement are different callers/mechanisms; preserve unresolved exact delta. |
488+
| ops / title_policy_scope | jev-1.13.0 | exclude_mcp_preserve_policy (confidence 0.75) | exclude_mcp_preserve_policy=0.81, represented=0.09, insufficient=0.08, remove_cli_title=0.02 | Preserve MCP/adapter seam exclusion and explicit neutral CLI title policy question. No title removal implemented or authorized by upstream diff alone. |
489+
| integration / linux_alias_behavior | jev-1.13.0 | missing_changed_behavior (confidence 0.55) | missing_changed_behavior=0.66, represented=0.20, partial_changed_behavior=0.13, insufficient=0.01 | Correct 00411ce7 changed-behavior disposition to missing at all frozen CLI targets: Apple-only alias branch excludes Linux, and ordinary directory continuation is absent. Shared surrounding security code is distinct. |
490+
| integration / opencode_adapter_exclusion | jev-1.13.0 | bounded_exclusion (confidence 0.69) | shared_missing=0.17, represented=0.03, insufficient=0.04, bounded_exclusion=0.76 | Retain bounded direct generator-seam exclusion for 8f3c1504: target installs instruction/skill assets and has no generator call; do not generalize to all 16 upstream-only-path rows. |
491+
492+
The counter and table-optimization answers retain substantial represented probability (0.34). They are split advice, not a correctness measure. The review findings rest on exact functions and changed callers; no confidence threshold grants acceptance.
493+
494+
### Required continuation
495+
496+
- Correct runtime committed-memory/budget claim.
497+
- Keep ops b04f5450 partial at exact mechanism level, f6afd613 policy unresolved; resolve other explicit ops remainders.
498+
- Correct integration 00411ce7 to missing changed Linux alias behavior; function-level review for at least29 partial rows and1 unresolved row remains required.
499+
- Do not count integration16 seam exclusions as independently approved based on single worker Jev call or this one sampled exclusion.
500+
- Independently review other109 full hashes before whole phase semantic closure.
501+
- Host collection/verification binding is separate from source review, runtime Jenkins and acceptance.
502+
503+
All worker scopes were processed, but integration explicitly did not complete function-level reading beyond its activation cluster. Its29 partial rows and1 unresolved row require deeper reads. Operations retains four explicit remainders. Runtime finish returned verification_required due missing host acceptance-command binding. Worker idle, saved rows and Jev execution do not establish semantic closure, runtime validation, review approval, acceptance or integration.
504+
505+
### Evidence
506+
507+
Exact requests: runtime-request-payload.json, ops-request-payload.json, integration-request-payload.json. Full results: corresponding *-response.json. Deterministic receipt: deterministic-integrity.json. Graph source/snippets/traces/coverage: graph/. Exact Git source excerpts are embedded in requests; target-scope-receipt.json records additional full-blob symbol checks. All115 independent primary diffs: *-diffs/. Full-hash independent-review crosswalk: review-crosswalk.jsonl. Machine-readable finding/distribution/advice-use record: review.json.
508+
509+
Graph generations match recorded exact-worktree indexes. Partial internal/cbm/cbm.c and CLI/activation paths were verified from Git source; no negative claim rests on graph absence. Broad coverage search was discovery-only, not an exhaustive pagination claim. Initial multi-path coverage invocation failed syntax; per-path retries succeeded, both outputs retained.

0 commit comments

Comments
 (0)