Skip to content

Commit dadc57d

Browse files
committed
fix(smoke): keep MCP tool inventory exact
Signed-off-by: Tamer <tamer.elbakkali@gmail.com>
1 parent 92abefa commit dadc57d

1 file changed

Lines changed: 21 additions & 7 deletions

File tree

‎scripts/smoke-invariants.sh‎

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -520,10 +520,10 @@ inv_mcp_initialize() {
520520
return 0
521521
}
522522

523-
# ── Invariant 4: tools/list returns all expected tools ─────────────────────
524-
# Cross-check against the canonical 14-tool list (TOOLS[] in src/mcp/mcp.c).
525-
EXPECTED_TOOLS="index_repository search_graph query_graph trace_path get_code_snippet get_graph_schema get_architecture search_code list_projects delete_project index_status detect_changes manage_adr ingest_traces"
526-
EXPECTED_TOOL_COUNT=14
523+
# ── Invariant 4: tools/list returns exactly the expected tools ─────────────
524+
# Cross-check against the canonical registry (TOOLS[] in src/mcp/mcp.c).
525+
EXPECTED_TOOLS="index_repository search_graph query_graph trace_path get_code_snippet get_file_outline get_graph_schema compare_graphs get_architecture search_code list_projects delete_project index_status check_index_coverage detect_changes manage_adr ingest_traces"
526+
EXPECTED_TOOL_COUNT="$(printf '%s\n' $EXPECTED_TOOLS | grep -c .)"
527527
inv_tools_list() {
528528
if ! mcp_alive; then
529529
fail "tools-list" "server not alive"
@@ -573,18 +573,29 @@ print(r.get("nextCursor") or "")' 2>/dev/null)"
573573
fail "tools-list" "got $got_count tools across $page page(s), expected $EXPECTED_TOOL_COUNT; names=[$got_names]"
574574
return
575575
fi
576-
local missing=""
576+
local missing="" extra="" duplicates=""
577577
local t
578578
for t in $EXPECTED_TOOLS; do
579579
case " $got_names " in
580580
*" $t "*) ;;
581581
*) missing="$missing $t" ;;
582582
esac
583583
done
584+
for t in $got_names; do
585+
case " $EXPECTED_TOOLS " in
586+
*" $t "*) ;;
587+
*) extra="$extra $t" ;;
588+
esac
589+
done
590+
duplicates="$(printf '%s\n' $got_names | sort | uniq -d | tr '\n' ' ')"
584591
if [ -n "$missing" ]; then
585592
fail "tools-list" "missing tools:$missing"
593+
elif [ -n "$extra" ]; then
594+
fail "tools-list" "unexpected tools:$extra"
595+
elif [ -n "$duplicates" ]; then
596+
fail "tools-list" "duplicate tools: $duplicates"
586597
else
587-
pass "tools-list (all $EXPECTED_TOOL_COUNT tools present)"
598+
pass "tools-list (exactly $EXPECTED_TOOL_COUNT unique tools present)"
588599
fi
589600
}
590601

@@ -626,7 +637,7 @@ inv_every_tool() {
626637
return
627638
fi
628639

629-
# name|minimal-args (JSON object) for the remaining 13 tools.
640+
# name|minimal-args (JSON object) for the remaining 16 tools.
630641
# Args chosen to be minimally valid per TOOLS[] required fields.
631642
local p="$PROJ_NAME"
632643
local -a CALLS
@@ -635,11 +646,14 @@ inv_every_tool() {
635646
"query_graph|{\"project\":\"$p\",\"query\":\"MATCH (n) RETURN n.name LIMIT 5\"}"
636647
"trace_path|{\"project\":\"$p\",\"function_name\":\"compute\",\"direction\":\"both\"}"
637648
"get_code_snippet|{\"project\":\"$p\",\"qualified_name\":\"compute\"}"
649+
"get_file_outline|{\"project\":\"$p\",\"file_path\":\"src/main.py\"}"
638650
"get_graph_schema|{\"project\":\"$p\"}"
651+
"compare_graphs|{\"base_project\":\"$p\",\"target_project\":\"$p\"}"
639652
"get_architecture|{\"project\":\"$p\"}"
640653
"search_code|{\"project\":\"$p\",\"pattern\":\"def \"}"
641654
"list_projects|{}"
642655
"index_status|{\"project\":\"$p\"}"
656+
"check_index_coverage|{\"project\":\"$p\",\"paths\":[\"src/main.py\"]}"
643657
"detect_changes|{\"project\":\"$p\"}"
644658
"manage_adr|{\"project\":\"$p\",\"mode\":\"get\"}"
645659
"ingest_traces|{\"project\":\"$p\",\"traces\":[]}"

0 commit comments

Comments
 (0)