Skip to content

Commit e3bfcc3

Browse files
committed
diag(version_cohort): name the decoded-but-invalid active identity fields
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent 2184389 commit e3bfcc3

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

‎src/daemon/version_cohort.c‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,6 +479,17 @@ cbm_version_cohort_status_t cbm_version_cohort_acquire(cbm_version_cohort_manage
479479
} else {
480480
cbm_daemon_hello_status_t comparison =
481481
cbm_daemon_hello_compare(&active, identity, conflict_out);
482+
if (comparison == CBM_DAEMON_HELLO_INVALID) {
483+
/* The record decoded but hello_compare rejected an identity
484+
* field as invalid (empty version/fingerprint/cache). Name
485+
* the decoded active values so the malformed field on the
486+
* Windows cross-process read path is visible. */
487+
cbm_log_warn(
488+
"version_cohort.active_identity_invalid", "version",
489+
active.semantic_version ? active.semantic_version : "<null>", "build",
490+
active.build_fingerprint ? active.build_fingerprint : "<null>", "cache",
491+
active.cache_fingerprint ? active.cache_fingerprint : "<null>");
492+
}
482493
const char *active_cache_fingerprint =
483494
active.cache_fingerprint ? active.cache_fingerprint : "";
484495
const char *requested_cache_fingerprint =

0 commit comments

Comments
 (0)