Repository navigation
Commit e3c1ea3
committed
doc-links(msbuild): a group's condition is evaluated once, not per child (S1, evaluator side)
The checkpoint writes an <ImportGroup>'s condition once into the project
blob (S1), but the evaluator still evaluated it again for every import of
the group, and an <ItemGroup>'s condition again for every <Using> of the
group: the product imports (or items) x condition length that S1 removed
from the blob came back as evaluator work.
An <ImportGroup>'s condition is now evaluated once, at the group's first
import, which is where MSBuild evaluates it: a property the group's first
import sets no longer takes the group's later imports away. A legacy blob
(the condition copied into every import) is still evaluated per import. An
<ItemGroup>'s condition is evaluated once per group for the items of one
pass; the final properties the items see do not change while they are read,
so the result is the same.
Tests: msbuild_import_group_condition_work and
msbuild_item_group_condition_work (doubling both the children and the
condition length at most doubles the evaluator's work counter; it
quadrupled), msbuild_import_group_condition_once.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent 429a40f commit e3c1ea3
2 files changed
Lines changed: 189 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
557 | 557 | | |
558 | 558 | | |
559 | 559 | | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
560 | 566 | | |
561 | 567 | | |
562 | 568 | | |
| |||
2609 | 2615 | | |
2610 | 2616 | | |
2611 | 2617 | | |
2612 | | - | |
2613 | | - | |
2614 | | - | |
| 2618 | + | |
| 2619 | + | |
| 2620 | + | |
| 2621 | + | |
2615 | 2622 | | |
2616 | 2623 | | |
2617 | 2624 | | |
| |||
2704 | 2711 | | |
2705 | 2712 | | |
2706 | 2713 | | |
2707 | | - | |
2708 | | - | |
| 2714 | + | |
| 2715 | + | |
| 2716 | + | |
| 2717 | + | |
| 2718 | + | |
| 2719 | + | |
| 2720 | + | |
| 2721 | + | |
| 2722 | + | |
| 2723 | + | |
| 2724 | + | |
| 2725 | + | |
2709 | 2726 | | |
| 2727 | + | |
2710 | 2728 | | |
2711 | 2729 | | |
2712 | 2730 | | |
| |||
2846 | 2864 | | |
2847 | 2865 | | |
2848 | 2866 | | |
| 2867 | + | |
| 2868 | + | |
| 2869 | + | |
| 2870 | + | |
| 2871 | + | |
| 2872 | + | |
| 2873 | + | |
| 2874 | + | |
| 2875 | + | |
| 2876 | + | |
| 2877 | + | |
| 2878 | + | |
| 2879 | + | |
| 2880 | + | |
| 2881 | + | |
| 2882 | + | |
| 2883 | + | |
| 2884 | + | |
| 2885 | + | |
| 2886 | + | |
2849 | 2887 | | |
2850 | | - | |
| 2888 | + | |
| 2889 | + | |
2851 | 2890 | | |
2852 | 2891 | | |
2853 | | - | |
2854 | | - | |
| 2892 | + | |
2855 | 2893 | | |
2856 | 2894 | | |
2857 | 2895 | | |
| |||
3111 | 3149 | | |
3112 | 3150 | | |
3113 | 3151 | | |
| 3152 | + | |
3114 | 3153 | | |
3115 | | - | |
| 3154 | + | |
3116 | 3155 | | |
3117 | 3156 | | |
3118 | 3157 | | |
| |||
3435 | 3474 | | |
3436 | 3475 | | |
3437 | 3476 | | |
| 3477 | + | |
3438 | 3478 | | |
3439 | | - | |
| 3479 | + | |
3440 | 3480 | | |
3441 | 3481 | | |
3442 | 3482 | | |
| |||
3682 | 3722 | | |
3683 | 3723 | | |
3684 | 3724 | | |
| 3725 | + | |
3685 | 3726 | | |
3686 | 3727 | | |
3687 | 3728 | | |
3688 | 3729 | | |
3689 | 3730 | | |
3690 | 3731 | | |
3691 | 3732 | | |
3692 | | - | |
| 3733 | + | |
3693 | 3734 | | |
3694 | 3735 | | |
3695 | 3736 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3483 | 3483 | | |
3484 | 3484 | | |
3485 | 3485 | | |
| 3486 | + | |
| 3487 | + | |
| 3488 | + | |
| 3489 | + | |
| 3490 | + | |
| 3491 | + | |
| 3492 | + | |
| 3493 | + | |
| 3494 | + | |
| 3495 | + | |
| 3496 | + | |
| 3497 | + | |
| 3498 | + | |
| 3499 | + | |
| 3500 | + | |
| 3501 | + | |
| 3502 | + | |
| 3503 | + | |
| 3504 | + | |
| 3505 | + | |
| 3506 | + | |
| 3507 | + | |
| 3508 | + | |
| 3509 | + | |
| 3510 | + | |
| 3511 | + | |
| 3512 | + | |
| 3513 | + | |
| 3514 | + | |
| 3515 | + | |
| 3516 | + | |
| 3517 | + | |
| 3518 | + | |
| 3519 | + | |
| 3520 | + | |
| 3521 | + | |
| 3522 | + | |
| 3523 | + | |
| 3524 | + | |
| 3525 | + | |
| 3526 | + | |
| 3527 | + | |
| 3528 | + | |
| 3529 | + | |
| 3530 | + | |
| 3531 | + | |
| 3532 | + | |
| 3533 | + | |
| 3534 | + | |
| 3535 | + | |
| 3536 | + | |
| 3537 | + | |
| 3538 | + | |
| 3539 | + | |
| 3540 | + | |
| 3541 | + | |
| 3542 | + | |
| 3543 | + | |
| 3544 | + | |
| 3545 | + | |
| 3546 | + | |
| 3547 | + | |
| 3548 | + | |
| 3549 | + | |
| 3550 | + | |
| 3551 | + | |
| 3552 | + | |
| 3553 | + | |
| 3554 | + | |
| 3555 | + | |
| 3556 | + | |
| 3557 | + | |
| 3558 | + | |
| 3559 | + | |
| 3560 | + | |
| 3561 | + | |
| 3562 | + | |
| 3563 | + | |
| 3564 | + | |
| 3565 | + | |
| 3566 | + | |
| 3567 | + | |
| 3568 | + | |
| 3569 | + | |
| 3570 | + | |
| 3571 | + | |
| 3572 | + | |
| 3573 | + | |
| 3574 | + | |
| 3575 | + | |
| 3576 | + | |
| 3577 | + | |
| 3578 | + | |
| 3579 | + | |
| 3580 | + | |
| 3581 | + | |
| 3582 | + | |
| 3583 | + | |
| 3584 | + | |
| 3585 | + | |
| 3586 | + | |
| 3587 | + | |
| 3588 | + | |
| 3589 | + | |
| 3590 | + | |
| 3591 | + | |
| 3592 | + | |
| 3593 | + | |
| 3594 | + | |
| 3595 | + | |
| 3596 | + | |
| 3597 | + | |
| 3598 | + | |
| 3599 | + | |
| 3600 | + | |
| 3601 | + | |
| 3602 | + | |
| 3603 | + | |
| 3604 | + | |
| 3605 | + | |
| 3606 | + | |
| 3607 | + | |
| 3608 | + | |
| 3609 | + | |
| 3610 | + | |
| 3611 | + | |
| 3612 | + | |
| 3613 | + | |
| 3614 | + | |
| 3615 | + | |
| 3616 | + | |
| 3617 | + | |
| 3618 | + | |
| 3619 | + | |
3486 | 3620 | | |
3487 | 3621 | | |
3488 | 3622 | | |
| |||
9837 | 9971 | | |
9838 | 9972 | | |
9839 | 9973 | | |
| 9974 | + | |
| 9975 | + | |
| 9976 | + | |
9840 | 9977 | | |
9841 | 9978 | | |
9842 | 9979 | | |
| |||
0 commit comments