Repository navigation
Commit e554a2a
committed
fix(go): no field-type hint for Go; it is a name guess, par-only
The parallel resolver re-picks a multi-candidate registry match through
try_field_type_hint. That helper capitalizes the receiver VARIABLE name
and accepts any candidate whose QN contains it as a substring: `t.Run`
on a *testing.T became `T` and bound a project `TBench.Run`. The
sequential resolver has no such step. The Go selector guard treated
field_type_hint as receiver-aware and kept it, so the same weak pick it
drops in sequential mode survived in parallel mode under a new name.
On caddy + prometheus, parallel and sequential CALLS diverged by 1,684
(this branch) and 5,560 (with receiver-qualified method QNs, which put
type names into more QNs). At base the gap is 84. SCIP precision of Go
field_type_hint is 0.016 at base.
Go no longer takes the hint. The guard keeps field_type_hint on the
shared weak list, and the fixture of both twins now pins the
`t.Run` case. A typed field call (lrp_go_s8, `s.repo.Find()`) resolves
through the Go LSP and is unaffected.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>1 parent 7528ec0 commit e554a2a
4 files changed
Lines changed: 51 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3298 | 3298 | | |
3299 | 3299 | | |
3300 | 3300 | | |
3301 | | - | |
| 3301 | + | |
| 3302 | + | |
| 3303 | + | |
| 3304 | + | |
| 3305 | + | |
| 3306 | + | |
| 3307 | + | |
| 3308 | + | |
| 3309 | + | |
3302 | 3310 | | |
3303 | 3311 | | |
3304 | 3312 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
755 | 755 | | |
756 | 756 | | |
757 | 757 | | |
758 | | - | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
759 | 763 | | |
760 | 764 | | |
761 | 765 | | |
762 | | - | |
763 | | - | |
764 | | - | |
765 | | - | |
766 | | - | |
767 | | - | |
768 | 766 | | |
769 | | - | |
| 767 | + | |
770 | 768 | | |
771 | 769 | | |
772 | 770 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8713 | 8713 | | |
8714 | 8714 | | |
8715 | 8715 | | |
| 8716 | + | |
| 8717 | + | |
| 8718 | + | |
| 8719 | + | |
| 8720 | + | |
| 8721 | + | |
| 8722 | + | |
| 8723 | + | |
| 8724 | + | |
| 8725 | + | |
| 8726 | + | |
| 8727 | + | |
| 8728 | + | |
| 8729 | + | |
| 8730 | + | |
| 8731 | + | |
| 8732 | + | |
| 8733 | + | |
| 8734 | + | |
| 8735 | + | |
| 8736 | + | |
| 8737 | + | |
| 8738 | + | |
| 8739 | + | |
8716 | 8740 | | |
8717 | 8741 | | |
8718 | 8742 | | |
| |||
8750 | 8774 | | |
8751 | 8775 | | |
8752 | 8776 | | |
| 8777 | + | |
| 8778 | + | |
8753 | 8779 | | |
8754 | 8780 | | |
8755 | 8781 | | |
| |||
8793 | 8819 | | |
8794 | 8820 | | |
8795 | 8821 | | |
| 8822 | + | |
| 8823 | + | |
8796 | 8824 | | |
8797 | 8825 | | |
8798 | 8826 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1673 | 1673 | | |
1674 | 1674 | | |
1675 | 1675 | | |
1676 | | - | |
1677 | | - | |
1678 | | - | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
1679 | 1680 | | |
1680 | | - | |
| 1681 | + | |
1681 | 1682 | | |
1682 | 1683 | | |
1683 | 1684 | | |
| |||
1697 | 1698 | | |
1698 | 1699 | | |
1699 | 1700 | | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
1700 | 1704 | | |
1701 | 1705 | | |
1702 | 1706 | | |
| |||
1706 | 1710 | | |
1707 | 1711 | | |
1708 | 1712 | | |
1709 | | - | |
1710 | | - | |
1711 | | - | |
1712 | 1713 | | |
1713 | 1714 | | |
1714 | 1715 | | |
| |||
0 commit comments