Skip to content

Commit ee2a4d6

Browse files
committed
Merge branch 'gq-l5/stack-a-1907' into gq-l5/stack-a-1913
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
2 parents ec1e8b8 + 4feb475 commit ee2a4d6

30 files changed

Lines changed: 2569 additions & 296 deletions

‎.codebase-memory.json‎

Lines changed: 39 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,30 @@
1414
},
1515
{
1616
"id": "engine",
17-
"paths": [".codebase-memory.json", "src/mcp/test_impact*", "src/store/store_impact.*"],
17+
"paths": [
18+
".codebase-memory.json",
19+
"src/mcp/test_impact*",
20+
"src/store/store_impact.*",
21+
"scripts/test-impact/**",
22+
"scripts/ci/test-impact-*"
23+
],
1824
"action": "run_all"
1925
},
2026
{
2127
"id": "build",
22-
"paths": ["scripts/**", "test-infrastructure/**", "pkg/**"],
28+
"paths": [
29+
"scripts/build.sh",
30+
"scripts/env.sh",
31+
"scripts/test.sh",
32+
"scripts/run-tests-parallel.sh",
33+
"scripts/run-test-wave.py",
34+
"scripts/path-safety.sh",
35+
"scripts/clean.sh",
36+
"scripts/suite-failure-report.sh",
37+
"scripts/ci/verify-shard-union.sh",
38+
"scripts/embed-frontend.sh",
39+
"/.gitattributes"
40+
],
2341
"action": "run_all"
2442
},
2543
{
@@ -35,13 +53,31 @@
3553
},
3654
{
3755
"id": "contracts",
38-
"paths": ["tests/**/*.{sh,py,json,txt}"],
56+
"paths": ["tests/**/*.{sh,py,json,txt,ps1}"],
3957
"action": "ignore"
4058
},
4159
{
4260
"id": "notices",
4361
"paths": ["NOTICE*", "CHANGELOG*", "THIRD_PARTY*"],
4462
"action": "ignore"
63+
},
64+
{
65+
"id": "repo-data",
66+
"paths": [
67+
"scripts/**",
68+
"pkg/**",
69+
"test-infrastructure/**",
70+
"docs/**",
71+
"**/*.md",
72+
"graph-ui/**",
73+
"tools/**",
74+
"tests/fuzz/corpus/**",
75+
"/{.clang-format,.clang-tidy,.cppcheck,.gitignore,.gitleaksignore,DCO,Formula}",
76+
"/{flake.lock,flake.nix,glama.json,install.ps1,install.sh,server.json}"
77+
],
78+
"action": "referencing_tests",
79+
"key": "path",
80+
"unreferenced": "ignore"
4581
}
4682
],
4783
"unmapped_files": "run_all",

‎.github/workflows/_test.yml‎

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ on:
2525
type: string
2626
default: all
2727
test_selection:
28-
description: 'PR test selection (smart CI): the artifact the select-tests job uploaded; the test-unix and test-windows legs run only its tests. Empty = every test (dry run, release, and any PR the selection does not narrow)'
28+
description: 'PR test selection (smart CI): the artifact the select-tests job uploaded; the Linux x86_64 test-unix leg runs only its tests, the arm64, macOS and Windows legs run every test. Empty = every test (dry run, release, and any PR the selection does not narrow)'
2929
type: string
3030
default: ''
3131

@@ -222,7 +222,11 @@ jobs:
222222
ccache-test-${{ matrix.os }}-${{ matrix.cc }}-
223223
224224
- name: Fetch the test selection
225-
if: ${{ inputs.test_selection != '' }}
225+
# Only the Linux x86_64 leg narrows (user decision 2026-10-16): the
226+
# coverage that justifies an omission comes from the Linux x86_64
227+
# producer, so arm64, macOS and Windows code under #ifdef has static
228+
# evidence only and those legs run every test.
229+
if: ${{ inputs.test_selection != '' && runner.os == 'Linux' && runner.arch == 'X64' }}
226230
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
227231
with:
228232
name: ${{ inputs.test_selection }}
@@ -234,7 +238,7 @@ jobs:
234238
CBM_TEST_SHARD: ${{ matrix.shard }}
235239
CBM_TEST_LEG: ${{ matrix.os }}-${{ matrix.cc }}
236240
CBM_SKIP_PERF: ${{ inputs.skip_perf && '1' || '' }}
237-
CBM_TEST_SELECTION_DIR: ${{ inputs.test_selection != '' && format('{0}/test-selection', runner.temp) || '' }}
241+
CBM_TEST_SELECTION_DIR: ${{ inputs.test_selection != '' && runner.os == 'Linux' && runner.arch == 'X64' && format('{0}/test-selection', runner.temp) || '' }}
238242
CCACHE_DIR: ${{ github.workspace }}/.ccache
239243
CCACHE_MAXSIZE: 1500M
240244

@@ -617,13 +621,6 @@ jobs:
617621
ccache-test-${{ matrix.os }}-${{ matrix.msystem }}-${{ github.ref }}-
618622
ccache-test-${{ matrix.os }}-${{ matrix.msystem }}-
619623
620-
- name: Fetch the test selection
621-
if: ${{ inputs.test_selection != '' }}
622-
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
623-
with:
624-
name: ${{ inputs.test_selection }}
625-
path: ${{ runner.temp }}/test-selection
626-
627624
- name: Test
628625
shell: msys2 {0}
629626
# AddressSanitizer is unavailable on native ARM64 Windows (LLVM ships no
@@ -651,7 +648,8 @@ jobs:
651648
CBM_TEST_SHARD: ${{ matrix.shard }}
652649
CBM_TEST_LEG: ${{ matrix.os }}-${{ matrix.msystem }}
653650
CBM_SKIP_PERF: ${{ inputs.skip_perf && '1' || '' }}
654-
CBM_TEST_SELECTION_DIR: ${{ inputs.test_selection != '' && format('{0}/test-selection', runner.temp) || '' }}
651+
# Windows legs run every test: see the Linux x86_64-only fetch in test-unix.
652+
CBM_TEST_SELECTION_DIR: ''
655653
CCACHE_DIR: ${{ github.workspace }}/.ccache
656654
CCACHE_MAXSIZE: 1500M
657655

‎.github/workflows/pr.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,16 @@ jobs:
8686
path: ${{ runner.temp }}/test-selection
8787
if-no-files-found: error
8888
overwrite: true
89+
# The selection a veto discarded (written only when one did): evidence
90+
# for the vetoes, never read by a test leg.
91+
- name: Upload the vetoed selection
92+
if: ${{ !cancelled() && steps.select.outcome != 'skipped' }}
93+
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
94+
with:
95+
name: test-selection-vetoed
96+
path: ${{ runner.temp }}/test-impact/selection-vetoed.json
97+
if-no-files-found: ignore
98+
overwrite: true
8999

90100
test:
91101
needs: [changes, lint, select-tests]

0 commit comments

Comments
 (0)